tests/test_edgesec.c code-coverage is inconsistent

[aloisklink]

Describe the bug

tests/test_edgesec.c code-coverage is inconsistent.

As an example, see #434 (comment).

This PR doesn't change anything in tests/test_edgesec.c, but somehow tests/test_edgesec.c had a code-coverage change. This is consistently happening with our PRs, which is a bit annoying, since we sometimes get a false-positive ❌ saying that the code-coverage got worse, but it turns out it's just tests/test_edgesec.c

Expected behavior

tests/test_edgesec.c code-coverage is consistent.

Screenshots

Additional context

It looks like the issue is this line:

edgesec/tests/test_edgesec.c

Line 60 in 595fe95

} else {

I'm guessing maybe some of the CI compilers might be using a different version of gcc that uses different optimisation? I have a WIP commit that will test this branch, which should fix this issue, see 80e1ee7

[aloisklink]

It looks like this is still an issue, as of dd4f7a6.

The issue seems to be that when GCC outputs the tracefile showing the code-coverage, it ignores this line, because it has no assembly associated with it:

edgesec/tests/test_edgesec.c

Line 79 in 39baecc

} else {

However, when Clang outputs their tracefile for code-coverage, it doesn't ignore this line.

The following line of code (the branch above the } else { line) is tested but only on the OpenWRT test preset, which only uses GCC.

edgesec/tests/test_edgesec.c

Line 78 in 39baecc

log_trace("RECEIVED ATTACH");

I think if we test this branch in Clang too, this should fix this issue.