refactor(attributes): fix STRUCT_PACKED in clang
#434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the [`__has_attribute`][1] macro to check for compiler support for `__attribute__((packed))`, so that `STRUCT_PACKED` also works on the Clang compiler. (`__has_attribute` is supported by GCC, Clang, IBM compiler, and even the Oracle® Solaris Studio C compiler). [1]: https://clang.llvm.org/docs/LanguageExtensions.html#has-attribute
Codecov Report
@@ Coverage Diff @@
## main #434 +/- ##
==========================================
- Coverage 53.14% 53.13% -0.01%
==========================================
Files 144 144
Lines 19897 19897
==========================================
- Hits 10574 10573 -1
- Misses 9323 9324 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
mereacre
approved these changes
Feb 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the
__has_attributemacro to check for compiler support for__attribute__((packed)), so thatSTRUCT_PACKEDalso works on the Clang compiler.(
__has_attributeis supported by GCC, Clang, IBM compiler, and even the Oracle® Solaris Studio C compiler).