test(edgesec): test "ATTACH" to ap server #473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, only the OpenWRT test presets of OpenWRT sends an "ATTACH" command to the AP server, which is compiled with GCC. This causes an issue with code-coverage, because this means that this branch is only covered by code compiled/tested with GCC, and not via LLVM/Clang. Testing this branch in Clang should fix this code-coverage issue.
Codecov Report
@@ Coverage Diff @@
## main #473 +/- ##
=======================================
Coverage 53.48% 53.49%
=======================================
Files 144 144
Lines 19963 19964 +1
=======================================
+ Hits 10678 10679 +1
Misses 9285 9285
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
mereacre
approved these changes
Mar 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, only the OpenWRT test presets of edgesec sends an "ATTACH" command to the AP server, which is compiled with GCC.
This causes an issue with code-coverage, because this means that this branch is only covered by code compiled/tested with GCC, and not via LLVM/Clang. Testing this branch in Clang should hopefully fix this code-coverage issue.
Should hopefully fix #435.