Compile libmnl at compile time
#150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Compiles libmnl in the `cmake --build` compile step, instead of compiling during the `cmake` configure step.
aloisklink
added
enhancement
aloisklink
changed the title
libmnl at compile time
aloisklink
added a commit
that referenced
this pull request
Jun 10, 2022
LIB_MAKEFLAGS was used to pass makeflags to libraries that were being compiled at configure time. As of #150 being merged, all libraries are now compiled at compile time, so this variable is no longer needed.
This was referenced Jun 10, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compiles
libmnlin thecmake --buildcompile step, instead of compiling during thecmakeconfigure step.After this PR is merged, every single library will have been converted to compile within
cmake --build, and therefore compile with multiprocessing!