Various CMake cleanups #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some CMake options only make sense to enable/show to the user if another CMake option is enabled. For example, setting BUILD_MNL_LIB=ON/OFF only makes sense if we're actually using libmnl when USE_NETLINK_SERVICE=ON
LIB_MAKEFLAGS was used to pass makeflags to libraries that were being compiled at configure time. As of #150 being merged, all libraries are now compiled at compile time, so this variable is no longer needed.
Previously, libnetlink was harded to compile in DEBUG mode. Now it should inherit EDGESec's compile mode.
POSITION_INDEPENDENT_CODE is the preferred way of enabling this in CMAKE, see https://cmake.org/cmake/help/latest/prop_tgt/POSITION_INDEPENDENT_CODE.html
aloisklink
added
refactor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various CMake cleanups:
build: depend cmake options on parent options
Some CMake options only make sense to enable/show to the user if another CMake option is enabled.
For example, setting
BUILD_MNL_LIB=ON/OFFonly makes sense if we're actually using libmnl whenUSE_NETLINK_SERVICE=ONbuild: remove LIB_MAKEFLAGS references
LIB_MAKEFLAGSwas used to pass makeflags to libraries that were being compiled at configure time.As of Compile
libmnlat compile time #150 being merged, all libraries are now compiled at compile time, so this variable is no longer needed.build: remove unused CMake defines
CROSS_COMPILE_EDGESEChad been replaced byCMAKE_CROSS_COMPILINGandBUILD_NL_LIBis unused.build(libnetlink): allow setting CMAKE_BUILD_TYPE
Previously, libnetlink was hard coded to compile in DEBUG mode.
Now it should inherit EDGESec's compile mode.