fix(debian): compile enabled header middleware #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The header middleware allows capturing metadata from PCAP files, and would be useful to be included in the `.deb` file.
These tests seem to be failing due the permissions/properties of the chroot that pbuilder uses. I can't figure out how to fix them, but we can temporarily disable them.
mereacre
approved these changes
Aug 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The header middleware allows capturing metadata from PCAP files, and would be useful to be included in the
.debfile.This will copy how we compile the OpenWRT version of edgesec, see https://github.com/nqminds/manysecured-openwrt-packages/blob/484ffebf2d21adfe21117ee4a8861a9af2dcfe2c/edgesec/Makefile#L62
Edit: The
test_run_captureandtest_sqlite_headerare failing in the pdebuild due to SQLITE read_only errors, so I've disabled them for the debuild. I think this is because pdebuild builds in a temporary file system, so I'm guessing there's some sort of permission error there? (or maybe the file-system doesn't support file-locks, which SQLite requires?)