fix: fix missing WITH_NETLINK_SERVICE in iface #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It looks like the WITH_NETLINK_SERVICE wasn't being defined properly, so iface was compiling with nothing enabled. This might also fix some WITH_UCI_SERVICE code, since according to https://cmake.org/cmake/help/latest/prop_dir/COMPILE_DEFINITIONS.html#prop_dir:COMPILE_DEFINITIONS add_compile_definitions() only applies to the current directory, so having it in `lib/uci.cmake` means it might not apply to `src/...` I've added an #error check too, to confirm the behaviour.
aloisklink
force-pushed
the
fix-broken-netlink-iface
branch
from
112f41d
to
7b79ca2
Compare
Adds a cmake error when no USE_*_SERVICE is enabled saying:
- You must define enable one of USE_NETLINK_SERVICE or USE_UCI_SERVICE
or USE_GENERIC_IP_SERVICE.
This should add the cacheVariable defines from Linux
aloisklink
force-pushed
the
fix-broken-netlink-iface
branch
from
57d7480
to
0faeb1f
Compare
Codecov Report
@@ Coverage Diff @@
## main #227 +/- ##
==========================================
- Coverage 43.67% 43.67% -0.01%
==========================================
Files 100 100
Lines 13178 13177 -1
==========================================
- Hits 5756 5755 -1
Misses 7422 7422
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like the WITH_NETLINK_SERVICE wasn't being defined properly, so iface was compiling with nothing enabled. This was causing the compiler to emit a warning about
paramsnot being used.I've added an
#errorcheck too if not iface service is enabled, to confirm the behaviour.