Fix failing WITH_CRYPT_SERVICE test #230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of having to make mock functions to fake a global_db, we can use built-in SQLite functionality, see [In-memory Databases And Shared Cache](https://www.sqlite.org/inmemorydb.html)
Codecov Report
@@ Coverage Diff @@
## main #230 +/- ##
=======================================
Coverage ? 45.56%
=======================================
Files ? 108
Lines ? 14949
Branches ? 0
=======================================
Hits ? 6811
Misses ? 8138
Partials ? 0
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
aloisklink
force-pushed
the
ci-test-crypt-service
branch
from
b671a05
to
6a1508a
Compare
This function was not working properly, as the step function was returning SQLITE_MISUSE.
Adds some basic tests for src/utils/sqliteu.h
aloisklink
force-pushed
the
ci-test-crypt-service
branch
from
6a1508a
to
faa7aeb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds CI tests for
linux-with-crypt.After adding these tests, I found that the tests were failing, since the
prepare_find_tablefunction was failing to find thestoredatabase, due to anSQLITE_MISUSEerror.I did a bit of refactoring to simplify the function and add error handling and the function and tests seem to work now.
Draft until #227 is merged