Cleanup sockctl tests #276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cleans up temporary files during test. Also removes the usage of tempnam, which is deprecated and throws a warning on use. The first line of the description in the tempnam manpage says: > _Never use this function_. Use mkstemp(3) or tmpfile(3) instead.
Cleanup some of the sockctl tests: - Moves variable declaration next to usage - Uses struct initialisation when possible - Replace 100 bytes client_addr buffer to 108 bytes
Codecov Report
@@ Coverage Diff @@
## main #276 +/- ##
==========================================
+ Coverage 47.86% 47.91% +0.04%
==========================================
Files 114 114
Lines 18204 18221 +17
==========================================
+ Hits 8713 8730 +17
Misses 9491 9491
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's probably easier to review each commit one by one!
The main point of this PR is to remove the use of
tempnamfrom this project, as it is deprecated and the compiler/linker throws a warning on use.The first line of the description in the tempnam manpage says:
I've also used
teardown()functions to automatically cleanup all of the sockctl temporary files, so that my/tmpfolder isn't filled with junk!In commit test(sockctl): refactor and cleanup tests, I've also done some general cleanup.