Improve code quality #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
nqt230
commented
Sep 10, 2022
nqt230
commented
- Refactor application launch process.
- Move Launcher.main method to Duke.main.
- Remove Launcher class since it is no longer used.
- Add constant TASK_TYPE_CHARACTER to ToDo, Deadline and Event. This is to centralize the information of which character refers to which type of task e.g. T associated to ToDo.
- Modify toString and toSaveFormatString methods in all subclasses of Task to make use of this constant.
- Modify Storage class to check against this constant when attempting to load in tasks from file.
- Move print statements to Duke's addToResponse method since all text to be displayed goes through that method.
* Refactor application launch process.
- Move Launcher.main method to Duke.main.
- Remove Launcher class since it is no longer used.
* Add constant TASK_TYPE_CHARACTER to ToDo, Deadline and Event. This is to centralize the information of which character refers to which type of task e.g. T associated to ToDo.
- Modify toString and toSaveFormatString methods in all subclasses of Task to make use of this constant.
- Modify Storage class to check against this constant when attempting to load in tasks from file.
* Move print statements to Duke's addToResponse method since all text to be displayed goes through that method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.