Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Improve AWS resource tagging and allow user to provide custom tags #249

Merged
merged 4 commits into from
Sep 4, 2020

Conversation

richford
Copy link
Member

@richford richford commented Sep 4, 2020

Resolves #248

@richford richford added this to the v0.5.0 milestone Sep 4, 2020
):
raise ValueError(
"If additional_tags is a list, it must be a list of "
"dictionaries of the form {'Key': key_val, 'Value': "
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a whacky format. Is there a good reason this is not: {key_val: value_val}?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that it's weird. Blame it on AWS and boto3:

They expect a list of dictionaries of the form

{"Key": key_val, "Value": value_val}

I wanted to keep both options for parameter input validation so that weirdos who know the AWS format can supply it. And normal folks can also supply a regular python dictionary.

But if this is too ugly for you to bear, we can require the regular python dictionary and then convert it behind the scenes.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. I suspected this is an AWS weirdness. So long as we support a normal API for normal people...

@arokem
Copy link
Member

arokem commented Sep 4, 2020

Looks good to me! Is it ready to merge?

@richford
Copy link
Member Author

richford commented Sep 4, 2020

Yep! 🚀

@arokem arokem merged commit a5ab64f into nrdg:master Sep 4, 2020
@richford richford deleted the aws-tagging branch September 4, 2020 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve resource tagging
2 participants