Add functions to clean up the cloudknot config file #250
Conversation
|
I believe these CI failures will be fixed after we rebase after merging #249 |
|
Okay, now I think the CI test failures will be fixed when we rebase after #249 |
richford
force-pushed
the
config-prune
branch
from
db78854
to
8c3a0e8
Compare
richford
changed the title
|
Ready for review! |
|
On second thought, let's hold on this until I can implement some more tests for this stuff. That would take care of #63. But it'll be a little bit before I can get to that. |
…ages and prune_batch_jobs
richford
force-pushed
the
config-prune
branch
from
843c96d
to
bfb173a
Compare
|
Resolves #63 |
|
The code looks good to me. Do you understand what Coveralls is going through? |
|
@arokem, I believe it's related to coverallsapp/github-action#30. The coveralls github action expects an .lcov file but pytest-cov doesn't produce that format. I just pushed a new commit that pip installs coveralls inside the github action and then uses the coveralls CLI. This should work but we won't know until the NRDG org grants access to coveralls. I also requested codecov access but you can safely ignore that request if coveralls works out for us. If it works, this would close #239 as well. |
|
Oh, it just worked. See e.g. https://coveralls.io/jobs/67461937
And then I think we're done with this PR. |
|
@arokem, just a reminder that the ball is in your court on approving coveralls-app access to NRDG, which I believe can be done here: https://github.com/settings/connections/applications/ad4c01c89848a307e228. |
|
Sorry - thanks for the reminder! Just approved.
…On Fri, Sep 11, 2020 at 9:57 AM Adam Richie-Halford < ***@***.***> wrote:
@arokem <https://github.com/arokem>, just a reminder that the ball is in
your court on approving coveralls-app access to NRDG, which I believe can
be done here:
https://github.com/settings/connections/applications/ad4c01c89848a307e228.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#250 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAA46NW4B45CWLB5A575R4TSFJJF5ANCNFSM4QZFQZLA>
.
|
|
I think it's ready now. The coverage badge won't be updated until we merge into master. And we'll have to see how coveralls responds in the next few PRs to see how we want to tweak those settings. But as far as this PR is concerned I think we're good to go. |
Resolves #8
Resolves #11
This PR introduces some functions in
cloudknot.configto "prune" config file entries. In this context, "prune" means to remove any config entries that do not refer to existing resources on AWS. We will provide pruning forParsKnotDockerRepoBatchJobDockerImageThis is related to #136, but does not resolve that issue. I think we should provide a CLI in another PR. This also does not solve the problem of removing unwanted resources that ARE on AWS. I'm thinking that we could do that through an interactive CLI but I'll add more details to #136 and limit the scope of this PR to config pruning through a Python API.