This repository has been archived by the owner on Dec 3, 2021. It is now read-only.
Add jupyter endpoint to ordered list after other lesson endpoints #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matt Oswalt <matt@oswalt.dev>
Signed-off-by: Matt Oswalt <matt@oswalt.dev>
Codecov Report
@@ Coverage Diff @@
## master #199 +/- ##
==========================================
- Coverage 27.69% 27.33% -0.37%
==========================================
Files 24 24
Lines 2401 2433 +32
==========================================
Hits 665 665
- Misses 1671 1703 +32
Partials 65 65
Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #198 I added some logic to create an ordered list in which endpoints should be started, to preserve network connection order for lessons that use it.
However, in doing this, only lessons that were explicitly provided in the lesson metadata were started. Any "hidden" endpoints (which is how we currently start jupyter pods for lessons that need it) didn't get started. Lessons that used a jupyter notebook would never start, because the health checks would still expect the jupyter server to be accessible, despite the fact that the pod was never created.
This PR fixes this, by moving the aforementioned logic ahead of the addition of a jupyter endpoint, and when creating the hidden endpoint for jupyter notebooks, an entry is added to both the ordered list, as well as the unordered map that is used for the API.