This repository has been archived by the owner on Dec 3, 2021. It is now read-only.
Add more detail to the progress modal based on Syringe API changes #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matt Oswalt <matt@keepingitclassless.net>
Signed-off-by: Matt Oswalt <matt@keepingitclassless.net>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Taking advantage of the changes in nre-learning/antidote-core#52, this PR modifies the modal dialog that comes up while a lesson is being loaded to provide the user with all the data available in the API changes, including both the overall lesson progress, as well as individual endpoint reachability.
This is a big UX improvement that will help users get a much better idea of how long it will take to get to their learning content.
In addition to the modal changes, some other changes in the code had to be made because of the change in endpoint datatypes.