This repository has been archived by the owner on Dec 3, 2021. It is now read-only.
Can pass this to runSnippetInTab() to run previous code snippet #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mierdin
suggested changes
Apr 14, 2019
src/main/webapp/js/antidote.js
Outdated
| @@ -42,10 +42,15 @@ function runSnippetInTab(tabName, snippetIndex) { | |||
| // Select tab | |||
| $('.nav-tabs a[href="#' + tabName + '"]').tab('show') | |||
|
|
|||
| if (typeof snippetIndex == 'number') { | |||
| var snippetText = document.getElementById('labGuide').getElementsByTagName('pre')[parseInt(snippetIndex)].innerText; | |||
| } else if (typeof snippetIndex == 'object') { | |||
There was a problem hiding this comment.
Suggested change
| } else if (typeof snippetIndex == 'object') { | |
| } else { |
Let's just catch all non-number cases here. If there's an issue accessing the object fields, that will get popped up to the javascript console.
There was a problem hiding this comment.
Applied the change according to your suggestion, and updated the CHANGELOG as well.
|
Excellent, thanks. I'd like to also update the nrelabs curriculum to use this (even though it's not strictly required based on your code here) so that people that look at other lessons for inspiration can see this as the de facto standard. Since this will result in a fairly big change (and v0.3.2 is out today) I'll merge this for the v0.4.0 release. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid batch update the index in "Run this snippet" for insertion/removal of single snippet, suggest to modify the code, so that it accepts either an index or
thisobject so it doesn't break existing lab guide content.After the change, we can pass the index as usual:
or pass
thisobject:and it will run the previous snippet just before the button object.