Dependency on tools.logging is incompatible with leiningen pedantic feature

[technomancy]

When using the latest version of Leiningen from git, a dependency on nrepl is injected into the list of dependencies whenever the :base profile is used (which is most of the time).

When this happens, org.clojure/tools.logging is pulled in as an indirect dependency. Any medium-to-large sized Clojure project already pulls in a different version of that library. Such projects which have the :pedantic? feature enabled will abort due to the dependency conflict, with no clear way to resolve the conflict.

We can't have any dependencies in the :base profile of Leiningen which themselves have dependencies.

Expected behavior

You can use org.clojure/tools.logging in a project with :pedantic? enabled.

Actual behavior

Aborting due to :pedantic? :abort

Steps to reproduce the problem

Run lein test on any project which has a dependency on org.clojure/tools.logging other than 0.4.1 when :pedantic? is turned on.

Environment & Version information

Leiningen running from git master.

[bbatsov]

Roger that. I’ll Remoev it and cut a new release.

…

On Thu, 29 Nov 2018 at 20:03, Phil Hagelberg ***@***.***> wrote: When using the latest version of Leiningen, a dependency on nrepl is injected into the list of dependencies whenever the :base profile is used (which is most of the time). When this happens, org.clojure/tools.logging is pulled in as an indirect dependency. Any medium-to-large sized Clojure project already pulls in a different version of that library. Such projects which have the :pedantic? feature enabled will abort due to the dependency conflict, with no clear way to resolve the conflict. We can't have any dependencies in the :base profile of Leiningen which themselves have dependencies. Expected behavior You can use org.clojure/tools.logging in a project with :pedantic? enabled. Actual behavior Aborting due to :pedantic? :abort Steps to reproduce the problem Run lein test on any project which has a dependency on org.clojure/tools.logging other than 0.4.1 when :pedantic? is turned on. Environment & Version information Leiningen running from git master. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#89>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAGVynf_4cUgR4Sr-GNRLr3TclL28IHlks5u0IPUgaJpZM4Y6z5-> .

[technomancy]

Thanks. Besides this we've got only one more issue and then should be good to release; I'm hoping within a week.

[bbatsov]

Done.