Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the default LED matrix levels for micro:bit v1 #62

Merged
merged 3 commits into from Jul 19, 2021
Merged

Fix the default LED matrix levels for micro:bit v1 #62

merged 3 commits into from Jul 19, 2021

Conversation

hargoniX
Copy link
Contributor

@hargoniX hargoniX commented Jul 19, 2021 •
edited

The micro:bit v1 Board constructor turns all LEDs on the board on per
default at the moment, we don't want that. Tested on a micro:bit v1.5.

@hargoniX
Fix the default LED matrix levels for micro:bit v1
6a958da 
The micro:bit v1 Board constructor turns all LEDs on the board on per
default at the moment, we don't want that.
@hargoniX
Remove the flickering workaround
eb8542a 
Now that the LEDs are initialized off per default there shouldn't be any
flickering anymore
@hargoniX
CHANGELOG entry
dd95a60
therealprof
therealprof approved these changes Jul 19, 2021
View reviewed changes
Copy link
Contributor

@therealprof therealprof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot.

bors r+

@bors
Copy link
Contributor

bors bot commented Jul 19, 2021

Build succeeded:

@bors bors bot merged commit 458d705 into nrf-rs:main Jul 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@therealprof therealprof therealprof approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hargoniX @therealprof