Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PWM module #200

Merged
merged 14 commits into from
Aug 26, 2020
Merged

Add PWM module #200

merged 14 commits into from
Aug 26, 2020

Conversation

kalkyl
Copy link
Contributor

@kalkyl kalkyl commented Aug 10, 2020

Added a HAL module for the PWM peripheral

LED demo of some different modes and features (nRF52840-DK):
https://github.com/kalkyl/nrf-hal/blob/pwm/examples/pwm-demo/src/main.rs

@Mirabellensaft
Copy link

Hi! I have looked over your PR, the pwm.rs looks good to me so far. Looking at the demo, it would be really helpful to have comments that explain what the different parts of the demo are about.

@kalkyl
Copy link
Contributor Author

kalkyl commented Aug 19, 2020

Thanks, good idea!

nrf-hal-common/src/pwm.rs Outdated Show resolved Hide resolved
nrf-hal-common/src/pwm.rs Outdated Show resolved Hide resolved
nrf-hal-common/src/pwm.rs Outdated Show resolved Hide resolved
@jonas-schievink jonas-schievink merged commit 63697e5 into nrf-rs:master Aug 26, 2020
@kalkyl kalkyl deleted the pwm branch September 4, 2020 13:38
@huntc
Copy link
Contributor

huntc commented May 8, 2021

Thanks for this great contribution @kalkyl.

Being a first-time user of PWM, I did find the example introducing many new concepts. I'm sure the example will be really useful to me over time, but I was wondering if you knew of "blinky-style" examples using Pwm and an RGB LED? I'm presently writing a BSP for the Thingy:91 and struggling a little: https://users.rust-lang.org/t/guidance-for-using-pwm-on-the-thingy-91/59516. I'd be happy to contribute an additional example here though if I can get mine to work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants