Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SPIS module #226

Merged
merged 9 commits into from
Sep 22, 2020
Merged

Add SPIS module #226

merged 9 commits into from
Sep 22, 2020

Conversation

kalkyl
Copy link
Contributor

@kalkyl kalkyl commented Sep 21, 2020

Added a module for the SPIS peripheral, using the embedded-dma traits.
Tested on nRF52840.

Demo of usage (pinout is for the ItsyBitsy nRF52840):
https://github.com/kalkyl/nrf-hal/blob/spis/examples/spis-demo/src/main.rs

jamesmunns
jamesmunns reviewed Sep 22, 2020
View reviewed changes
Copy link
Member

@jamesmunns jamesmunns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, I'll plan on using this pretty much immediately!

I did have a couple nits, but nothing huge :)

nrf-hal-common/src/spis.rs Outdated Show resolved Hide resolved
nrf-hal-common/src/spis.rs Show resolved Hide resolved
nrf-hal-common/src/spis.rs Outdated Show resolved Hide resolved
nrf-hal-common/src/spis.rs Show resolved Hide resolved
nrf-hal-common/src/spis.rs Outdated Show resolved Hide resolved
jamesmunns
jamesmunns requested changes Sep 22, 2020
View reviewed changes
nrf-hal-common/src/spis.rs Outdated Show resolved Hide resolved
@jamesmunns
Copy link
Member

Also, could you please add this to the changelog?

@kalkyl
Copy link
Contributor Author

kalkyl commented Sep 22, 2020

Overall looks good, I'll plan on using this pretty much immediately!

I did have a couple nits, but nothing huge :)

Thanks for your comments, agreed and fixed :)

@jamesmunns jamesmunns merged commit 3ce300c into nrf-rs:master Sep 22, 2020
@kalkyl kalkyl deleted the spis branch September 22, 2020 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamesmunns jamesmunns Awaiting requested review from jamesmunns

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kalkyl @jamesmunns