52811

[Yatekii]

No description provided.

[jacobrosenthal]

This needs to get removed too? Or do we intend to define this environment variable
https://github.com/nrf-rs/nrf-hal/blob/3ce300c0d4c3ed0d62bbf247ce14cb2de9f0bade/nrf-hal-common/build.rs

[Yatekii]

This needs to get removed too? Or do we intend to define this environment variable
https://github.com/nrf-rs/nrf-hal/blob/3ce300c0d4c3ed0d62bbf247ce14cb2de9f0bade/nrf-hal-common/build.rs

I don't see why this should be removed? It is helpful? :)

[jacobrosenthal]

ah yeah nevermind :)

[jonas-schievink]

Looks good! Needs a rebase to fix the merge conflicts though.

Have the problems with the SVD been fixed or are there still workarounds needed?

[Yatekii]

I rebased this onto master to make it build again. Ofc it got into conflict with the PR I merged earlier today =)

I patched the SVD manually to be in line with all the other pac crates. It was my understanding from the comments on Matrix that all the SVDs have manual adjustments. It only really was changes in the SPI section (swapoped SPI0 and SPI1 naming wise :))

[jonas-schievink]

I patched the SVD manually to be in line with all the other pac crates. It was my understanding from the comments on Matrix that all the SVDs have manual adjustments. It only really was changes in the SPI section (swapoped SPI0 and SPI1 naming wise :))

Yup, that's good.

[Yatekii]

Ok, I think all the changes have been made as requested :)