Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uart example #317

Merged
merged 2 commits into from
May 19, 2021
Merged

Uart example #317

merged 2 commits into from
May 19, 2021

Conversation

huntc
Copy link
Contributor

@huntc huntc commented May 14, 2021

Provides the simplest example of using UART for both the 52840 and 9160.

Tested successfully on:

  • nrf52840-dk
  • nrf9160-dk
  • Thingy:91 (having modified the GPIO pins locally)

Copy link
Contributor Author

@huntc huntc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jonathanpallant Can you elaborate further on the changes re 1ba3630 and why they are necessary? I was expecting to implement the nrfx workaround when initialising the UART for the 53 and 91 boards (see description), not a change for all boards. Thanks.

@huntc
Copy link
Contributor Author

huntc commented May 15, 2021

@jonathanpallant Can you elaborate further on the changes re 1ba3630 and why they are necessary? I was expecting to implement the nrfx workaround when initialising the UART for the 53 and 91 boards (see description), not a change for all boards. Thanks.

I've just seen #319. I shall revert your commit here @jonathanpallant and turn this PR into simply providing an example of using UART for nrf-hal. Thanks.

@huntc huntc changed the title Uart workaround Uart example May 15, 2021
@huntc huntc marked this pull request as ready for review May 15, 2021 06:04
@huntc
Copy link
Contributor Author

huntc commented May 15, 2021

@jonathanpallant Reverted your commit given the UART improvements/fixes elsewhere and made this just an example of how to set the UART up.

examples/hello-world/memory.x Outdated Show resolved Hide resolved
Provides a simple UART example so that we can test out UART on the nRF52840 and nRF9160
@huntc
Copy link
Contributor Author

huntc commented May 18, 2021

No more changes expected here. Please review/merge accordingly.

Copy link
Contributor

@thejpster thejpster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should remove embed.toml, and add 9160 to the xtask list, but otherwise looks OK.

@huntc
Copy link
Contributor Author

huntc commented May 19, 2021

I think we should remove embed.toml

I provided the embed.toml to be consistent with the other examples. Could we look at the example deployment strategy as a separate issue to this PR? All but one of the examples has an embed.toml.

and add 9160 to the xtask list, but otherwise looks OK.

I will do this shortly. Thanks.

@huntc
Copy link
Contributor Author

huntc commented May 19, 2021

The 9160 for the hello world example is now included in the xtask.

@thejpster
Copy link
Contributor

I think we should remove embed.toml

I provided the embed.toml to be consistent with the other examples. Could we look at the example deployment strategy as a separate issue to this PR? All but one of the examples has an embed.toml.

Oh! I totally didn't spot they'd been added to all the other examples. Yes, of course, we should be consistent.

@thejpster
Copy link
Contributor

bors r+

@bors
Copy link
Contributor

bors bot commented May 19, 2021

Build succeeded:

@bors bors bot merged commit b2e5b97 into nrf-rs:master May 19, 2021
@huntc huntc deleted the uart-workaround branch May 19, 2021 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants