Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ieee802154: handle the transitory state TXDISABLE #369

Merged
merged 1 commit into from
Jan 3, 2022

Conversation

japaric
Copy link
Contributor

@japaric japaric commented Dec 21, 2021

after PR #356 the radio is disabled after every send operation.
if one calls recv immediately after send, recv can observe the radio in the TXDISABLE state
TXDISABLE is a transitory state that leads to the final DISABLED state which the impl knows how to handle

this PR adds logic to handle the transitory TXDISABLE state

fixes #368


I have checked that the programs in https://github.com/ferrous-systems/embedded-trainings-2020 work again with this change

after PR nrf-rs#356 the radio is disabled after every `send` operation.
if one calls `recv` immediately after `send`, `recv` can observe the radio in the TXDISABLE state
TXDISABLE is a transitory state that leads to the final DISABLED state which the impl knows how to handle

this PR adds logic to handle the transitory TXDISABLE state

fixes nrf-rs#368
@jonas-schievink
Copy link
Contributor

bors r+

bors bot added a commit that referenced this pull request Jan 3, 2022
369: ieee802154: handle the transitory state TXDISABLE r=jonas-schievink a=japaric

after PR #356 the radio is disabled after every `send` operation.
if one calls `recv` immediately after `send`, `recv` can observe the radio in the TXDISABLE state
TXDISABLE is a transitory state that leads to the final DISABLED state which the impl knows how to handle

this PR adds logic to handle the transitory TXDISABLE state

fixes #368

---

I have checked that the programs in https://github.com/ferrous-systems/embedded-trainings-2020 work again with this change

Co-authored-by: Jorge Aparicio <jorge.aparicio@ferrous-systems.com>
@bors
Copy link
Contributor

bors bot commented Jan 3, 2022

Build failed:

bors bot added a commit that referenced this pull request Jan 3, 2022
370: Use the new Cargo resolver r=jonas-schievink a=jonas-schievink

Should avoid the CI failure in #369 (comment)

bors r+

Co-authored-by: Jonas Schievink <jonas.schievink@ferrous-systems.com>
@jonas-schievink
Copy link
Contributor

bors r+

@bors
Copy link
Contributor

bors bot commented Jan 3, 2022

Build succeeded:

@bors bors bot merged commit 3fd866a into nrf-rs:master Jan 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ieee802154: Radio::send followed by Radio::recv panics with v0.14
2 participants