Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use is_connected to determine whether a ctx/rtx was connected to uarte #397

Merged
merged 1 commit into from
Sep 15, 2022
Merged

Use is_connected to determine whether a ctx/rtx was connected to uarte #397

merged 1 commit into from
Sep 15, 2022

Conversation

hdoordt
Copy link
Contributor

@hdoordt hdoordt commented Sep 15, 2022

Uarte::free method uses bit_is_set to determine whether a pin was connected to cts and rts. However, a set bit represents a disconnected pin. Use is_connected() instead to do the inversion.

@jonas-schievink
Copy link
Contributor

Thanks!

bors r+

@bors
Copy link
Contributor

bors bot commented Sep 15, 2022

Build succeeded:

@bors bors bot merged commit 612902a into nrf-rs:master Sep 15, 2022
@jonas-schievink jonas-schievink mentioned this pull request Oct 26, 2022
Merged
bors bot added a commit that referenced this pull request Oct 26, 2022
@bors
Merge #407
31208d0 
407: Change all psel tests to use `is_connected` r=jonas-schievink a=jonas-schievink

Applies #397 to the whole HAL.

bors r+

Co-authored-by: Jonas Schievink <jonas.schievink@ferrous-systems.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hdoordt @jonas-schievink