Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR updates nrfxlib to v1.4.2, which is the latest stable version. v1.5.0 is almost released, but will prove to be a bigger albeit more promising update. I required this update due to the better socket connection establishment implementation in the newer bsdlib.
Note that temporarily I include my own fork of nrfxlib-sys, which I updated without being aware of the previous efforts by @jonathanpallant. Once nrf-rs/nrfxlib-sys#2 gets merged and released I'll change this merge request to point to the canonical one again. One minor issue is that this new nrfxlib-sys requires nightly, until
-Zfeatures=host_dep
ends up in stable. However that should not be a blocking issue for this merge request.The changes required to update this library (afaik) are as follows:
None
is no longer an appropriate value.trace_on
should always be true. Perhaps we should not give the option to the end user.nrf_pollfd
got renamed upstream.strncpy
, which I added and has been merged at Add strncpy. rust-embedded-community/tinyrlibc#2.I also fixed a minor issue with debug logging
NrfSockAddrIn
objects. We could move that out of this MR if so desired.