Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update west.yml for new SDC in nrfxlib v2.4-branch #13656

Merged
merged 2 commits into from
Jan 18, 2024
Merged

Update west.yml for new SDC in nrfxlib v2.4-branch #13656

merged 2 commits into from
Jan 18, 2024

Conversation

guwa
Copy link
Contributor

@guwa guwa commented Jan 18, 2024

No description provided.

@github-actions github-actions bot added changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. manifest labels Jan 18, 2024
@guwa guwa requested a review from cvinayak January 18, 2024 13:04
@NordicBuilder
Copy link
Contributor

The following west manifest projects have been modified in this Pull Request:

Name Old Revision New Revision Diff
nrfxlib nrfconnect/sdk-nrfxlib@v2.4.2 nrfconnect/sdk-nrfxlib@f635ec9 (v2.4-branch) nrfconnect/sdk-nrfxlib@v2.4.2..f635ec97

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@NordicBuilder
Copy link
Contributor

NordicBuilder commented Jan 18, 2024 •
edited

Test specification

CI/Jenkins/NRF

  • Integration Platforms

CI/Jenkins/integration

Test Module File based changes Manually selected West overwrite
desktop52_verification X
test-fw-nrfconnect-ble X
test-fw-nrfconnect-ble_mesh X
test-fw-nrfconnect-ble_samples X
test-fw-nrfconnect-chip X
test-fw-nrfconnect-fem X
test-fw-nrfconnect-rs X
test-fw-nrfconnect-zigbee X
test-sdk-find-my X
test-sdk-homekit X

Detailed information of selected test modules

Note: This message is automatically posted and updated by the CI

@jostn jostn mentioned this pull request Jan 18, 2024
Closed
@guwa guwa force-pushed the v2.4-branch branch 2 times, most recently from e65f9d1 to 24f23c8 Compare January 18, 2024 13:34
@guwa
west manifest: Update west.yml for new SDC in nrfxlib v2.4-branch
1d97bdd 
Update nrfxlib with new Softdevice controller

Signed-off-by: Guojun Wang <guojun.wang@nordicsemi.no>
@guwa guwa requested a review from gmarull as a code owner January 18, 2024 14:37
@github-actions github-actions bot added the doc-required PR must not be merged without tech writer approval. label Jan 18, 2024
@divipillai
Copy link
Contributor

divipillai commented Jan 18, 2024 •
edited

@gmarull : The homekit issue that was seen in the 2.5 branch is seen in the 2.4 branch. The fix is added in this PR as per PR #13252.

Could you please check this.

@gmarull
Copy link
Member

gmarull commented Jan 18, 2024

could you guys just cherry-pick the commit from 2.5 branch?

@divipillai divipillai added this to the 2.4.3 milestone Jan 18, 2024
@gmarull @guwa
doc: extensions: software_maturity_table: skip missing features
92e59ac 
If a feature is not available (e.g. homekit), just log it as a debug
message but do not error, so the build can continue.

Signed-off-by: Gerard Marull-Paretas <gerard.marull@nordicsemi.no>
(cherry picked from commit 2401e61)
Signed-off-by: Guojun Wang <guojun.wang@nordicsemi.no>
@NordicBuilder
Copy link
Contributor

You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds.

Note: This comment is automatically posted by the Documentation Publishing GitHub Action.

@cvinayak
Copy link
Contributor

could you guys just cherry-pick the commit from 2.5 branch?

@gmarull it should be cherry-picked now... please approve this PR is ok by you.

@guwa
Copy link
Contributor Author

guwa commented Jan 18, 2024

The CI failure can be ignored after analysis.
FEM CI failed due to "ValueError: SHA b'10b62d40f7b95454a4029afbe41571c252324ad2' could not be resolved, git returned: b'10b62d40f7b95454a4029afbe41571c252324ad2 missing'"
RS CI failed due to "ValueError: SHA b'3ca1fdc8a108f2ec9dd60a67225968ad1c74be19' could not be resolved, git returned: b'3ca1fdc8a108f2ec9dd60a67225968ad1c74be19 missing'"

The change should not affect these domain and can be ignored.

@guwa
Copy link
Contributor Author

guwa commented Jan 18, 2024

ble_mesh passsed with rerun. The failure was related with code checkout.

@shanthanordic
Copy link

Failures are accepted based on risk

@cvinayak cvinayak merged commit 3bd172e into nrfconnect:v2.4-branch Jan 18, 2024
18 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cvinayak cvinayak cvinayak approved these changes

@shanthanordic shanthanordic shanthanordic approved these changes

@carlescufi carlescufi Awaiting requested review from carlescufi carlescufi is a code owner

@tejlmand tejlmand Awaiting requested review from tejlmand tejlmand is a code owner

@gmarull gmarull Awaiting requested review from gmarull gmarull is a code owner

Assignees
No one assigned
Labels
changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. doc-required PR must not be merged without tech writer approval. manifest manifest-nrfxlib
Projects
None yet
Milestone
2.4.3
6 participants
@guwa @NordicBuilder @divipillai @gmarull @cvinayak @shanthanordic