[nrf fromtree] bluetooth: samples: Add hci_uart_async #1367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexstanoev-nordic
requested review from
alwa-nordic and
carlescufi
as code owners
hermabe
approved these changes
Oct 25, 2023
There was a problem hiding this comment.
Might need zephyrproject-rtos/zephyr@fae3cdd as well since it removes some changes added by the cherry-picked commits.
alwa-nordic
approved these changes
Oct 25, 2023
It looks like it's not strictly needed. It's just removing a build assert that is now ensured by the Kconfig of the serial mock. The asserts are still valid. |
`vnd,serial` is a virtual device which does not have an address. Signed-off-by: Aleksander Wasaznik <aleksander.wasaznik@nordicsemi.no> (cherry picked from commit 0e83c66)
This allows testing code that uses the UART interrupt-driven API and UART asynchronous API. Signed-off-by: Aleksander Wasaznik <aleksander.wasaznik@nordicsemi.no> (cherry picked from commit 4d926ac)
This sample is an alternative implementation of hci_uart. The new sample differs from the existing sample in that it uses the async UART API instead of the interrupt driven API. Included in this commit is a new test for HCI UART flow control. It's enabled for hci_uart_async. The test can excercise also the existing hci_uart sample (with some minimal changes to allow compiling in the mock controller and test suite). The existing hci_uart sample currently fails the flow control test. Signed-off-by: Aleksander Wasaznik <aleksander.wasaznik@nordicsemi.no> (cherry picked from commit 347ce7a)
… build Some dependencies where missing from the build_all test for the modem_cellular.c driver. These have been added. Signed-off-by: Bjarki Arge Andreasen <baa@trackunit.com> (cherry picked from commit 7fb10c8)
…efined This commit fixes an error where the irq_isr callback is set to an undefined variable instead of NULL. Signed-off-by: Bjarki Arge Andreasen <baa@trackunit.com> (cherry picked from commit ebd6681)
…nfig This commit moves the dependency management between the RING_BUFFER and UART_ASYNC_API or UART_INTERRUPT_DRIVEN options to the Kconfig Kconfig.test. If either UART API options listed are selected, the RING_BUFFER option must be selected. This is now handled automatically by Kconfig instead of causing a build assert. The asserts where added with this PR #59880, and are removed in this commit. Signed-off-by: Bjarki Arge Andreasen <baa@trackunit.com> (cherry picked from commit d118d19)
Many boards do not build properly if UART_ASYNC_API is enabled, which is causing an overly large list of targets to exclude for the build_all.modem.modem_cellular.build test suite. This commit instead specifies 4 emulated boards, two of 32-bit, two of 64-bit instead. Signed-off-by: Bjarki Arge Andreasen <baa@trackunit.com> (cherry picked from commit b054d16)
The serial_test.c driver uses size_t to store read_size, which becomes a 64-bit type when built for 64-bit architectures. This is incompatible with the print format %d which is 32-bit. Updated to %zd Signed-off-by: Bjarki Arge Andreasen <baa@trackunit.com> (cherry picked from commit cc219c0)
alexstanoev-nordic
force-pushed
the
cherry_pick_hci_uart_async
branch
from
13f4a45
to
39b732c
Compare
I pulled in the whole patchset from PR 63238 as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of all commits from zephyrproject-rtos/zephyr#59880 to bring in samples/bluetooth/hci_uart_async