Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bluetooth: Samples: Add hci_uart_async #59880

Merged
merged 3 commits into from Sep 28, 2023
Merged

Bluetooth: Samples: Add hci_uart_async #59880

merged 3 commits into from Sep 28, 2023

Conversation

alwa-nordic
Copy link
Collaborator

@alwa-nordic alwa-nordic commented Jun 30, 2023 •
edited

This sample is an alternative implementation of hci_uart. The new sample differs from the existing sample in that it uses the async UART API instead of the interrupt driven API.

Included in this commit is a new test for HCI UART flow control. It's enabled for hci_uart_async. The test can also excercise the existing hci_uart sample (with some minimal changes to allow compiling in the mock controller and test suite). The existing hci_uart sample currently fails this flow control test.

@zephyrbot zephyrbot added area: UART Universal Asynchronous Receiver-Transmitter area: Bluetooth area: Devicetree Binding PR modifies or adds a Device Tree binding labels Jun 30, 2023
jori-nordic
jori-nordic previously approved these changes Jul 4, 2023
View reviewed changes
@alwa-nordic alwa-nordic mentioned this pull request Jul 7, 2023
Open
jhedberg
jhedberg requested changes Jul 12, 2023
View reviewed changes
Copy link
Member

@jhedberg jhedberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please split the non-Bluetooth changes (to serial_test.c, serial_test.h, and vnd,serial.yaml) into its own commit

@alwa-nordic
dts: bindings: Remove reg from vnd,serial
231de56 
`vnd,serial` is a virtual device which does not have an address.

Signed-off-by: Aleksander Wasaznik <aleksander.wasaznik@nordicsemi.no>
jhedberg
jhedberg previously approved these changes Sep 14, 2023
View reviewed changes
cvinayak
cvinayak previously requested changes Sep 14, 2023
View reviewed changes
Copy link
Contributor

@cvinayak cvinayak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add sample.yaml file with supported platforms

jori-nordic
jori-nordic previously approved these changes Sep 14, 2023
View reviewed changes
@alwa-nordic
bluetooth: samples: Add hci_uart_async
6792520 
This sample is an alternative implementation of hci_uart. The new sample
differs from the existing sample in that it uses the async UART API
instead of the interrupt driven API.

Included in this commit is a new test for HCI UART flow control. It's
enabled for hci_uart_async. The test can excercise also the existing
hci_uart sample (with some minimal changes to allow compiling in the
mock controller and test suite). The existing hci_uart sample currently
fails the flow control test.

Signed-off-by: Aleksander Wasaznik <aleksander.wasaznik@nordicsemi.no>
@cvinayak cvinayak dismissed their stale review September 19, 2023 03:02

My requests to add samples.yaml is handled

@jhedberg jhedberg merged commit 347ce7a into zephyrproject-rtos:main Sep 28, 2023
19 checks passed
bjarki-trackunit pushed a commit that referenced this pull request Sep 28, 2023
tests: build_all: modem: Remove UART_INTERRUPT_DRIVEN dep
0d0e12e 
The dependency for UART_INTERRUPT_DRIVEN causes a build
assert within the serial_test.c driver, after update
from this PR #59880

This commit simply removes this dependency.

Signed-off-by: Bjarki Arge Andreasen <baa@trackunit.com>
bjarki-trackunit pushed a commit that referenced this pull request Sep 28, 2023
tests: build_all: modem: Remove UART_INTERRUPT_DRIVEN dep
93cd013 
The dependency for UART_INTERRUPT_DRIVEN causes a build
assert within the serial_test.c driver, after update
from this PR #59880

This commit simply removes this dependency.

Signed-off-by: Bjarki Arge Andreasen <baa@trackunit.com>
bjarki-trackunit pushed a commit that referenced this pull request Sep 28, 2023
tests: build_all: modem: Remove UART_INTERRUPT_DRIVEN dep
0beafc2 
The dependency for UART_INTERRUPT_DRIVEN causes a build
assert within the serial_test.c driver, after update
from this PR #59880

This commit simply removes this dependency.

Signed-off-by: Bjarki Arge Andreasen <baa@trackunit.com>
bjarki-trackunit pushed a commit that referenced this pull request Sep 28, 2023
drivers: serial: serial_test: Move ring bug dep to Kconfig
299b02f 
This commit moves the dependency management between the
RING_BUFFER and UART_ASYNC_API or UART_INTERRUPT_DRIVEN
options to the Kconfig Kconfig.test.

If either UART API options listed are selected, the
RING_BUFFER option must be selected. This is now handled
automatically by Kconfig instead of causing a build
assert.

The asserts where added with this PR #59880, and are
removed in this commit.

Signed-off-by: Bjarki Arge Andreasen <baa@trackunit.com>
@bjarki-trackunit bjarki-trackunit mentioned this pull request Sep 28, 2023
Merged
bjarki-trackunit pushed a commit that referenced this pull request Sep 28, 2023
drivers: serial: serial_test: Move ring bug dep to Kconfig
fbd4dfa 
This commit moves the dependency management between the
RING_BUFFER and UART_ASYNC_API or UART_INTERRUPT_DRIVEN
options to the Kconfig Kconfig.test.

If either UART API options listed are selected, the
RING_BUFFER option must be selected. This is now handled
automatically by Kconfig instead of causing a build
assert.

The asserts where added with this PR #59880, and are
removed in this commit.

Signed-off-by: Bjarki Arge Andreasen <baa@trackunit.com>
bjarki-trackunit pushed a commit that referenced this pull request Sep 28, 2023
drivers: serial: serial_test: Move ring buf dep to Kconfig
f73d1bf 
This commit moves the dependency management between the
RING_BUFFER and UART_ASYNC_API or UART_INTERRUPT_DRIVEN
options to the Kconfig Kconfig.test.

If either UART API options listed are selected, the
RING_BUFFER option must be selected. This is now handled
automatically by Kconfig instead of causing a build
assert.

The asserts where added with this PR #59880, and are
removed in this commit.

Signed-off-by: Bjarki Arge Andreasen <baa@trackunit.com>
bjarki-trackunit pushed a commit that referenced this pull request Sep 28, 2023
drivers: serial: serial_test: Move ring buf dep to Kconfig
fae3cdd 
This commit moves the dependency management between the
RING_BUFFER and UART_ASYNC_API or UART_INTERRUPT_DRIVEN
options to the Kconfig Kconfig.test.

If either UART API options listed are selected, the
RING_BUFFER option must be selected. This is now handled
automatically by Kconfig instead of causing a build
assert.

The asserts where added with this PR #59880, and are
removed in this commit.

Signed-off-by: Bjarki Arge Andreasen <baa@trackunit.com>
nashif pushed a commit that referenced this pull request Sep 28, 2023
@nashif
drivers: serial: serial_test: Move ring buf dep to Kconfig
d118d19 
This commit moves the dependency management between the
RING_BUFFER and UART_ASYNC_API or UART_INTERRUPT_DRIVEN
options to the Kconfig Kconfig.test.

If either UART API options listed are selected, the
RING_BUFFER option must be selected. This is now handled
automatically by Kconfig instead of causing a build
assert.

The asserts where added with this PR #59880, and are
removed in this commit.

Signed-off-by: Bjarki Arge Andreasen <baa@trackunit.com>
najumon1980 pushed a commit to najumon1980/zephyr that referenced this pull request Oct 4, 2023
@najumon1980
drivers: serial: serial_test: Move ring buf dep to Kconfig
06b2d03 
This commit moves the dependency management between the
RING_BUFFER and UART_ASYNC_API or UART_INTERRUPT_DRIVEN
options to the Kconfig Kconfig.test.

If either UART API options listed are selected, the
RING_BUFFER option must be selected. This is now handled
automatically by Kconfig instead of causing a build
assert.

The asserts where added with this PR zephyrproject-rtos#59880, and are
removed in this commit.

Signed-off-by: Bjarki Arge Andreasen <baa@trackunit.com>
Chenhongren pushed a commit to Chenhongren/zephyr that referenced this pull request Oct 4, 2023
drivers: serial: serial_test: Move ring buf dep to Kconfig
3121af3 
This commit moves the dependency management between the
RING_BUFFER and UART_ASYNC_API or UART_INTERRUPT_DRIVEN
options to the Kconfig Kconfig.test.

If either UART API options listed are selected, the
RING_BUFFER option must be selected. This is now handled
automatically by Kconfig instead of causing a build
assert.

The asserts where added with this PR zephyrproject-rtos#59880, and are
removed in this commit.

(cherry picked from commit d118d19)

Original-Signed-off-by: Bjarki Arge Andreasen <baa@trackunit.com>
GitOrigin-RevId: d118d19
Change-Id: Ic44bf835a03bb6fa7b4b3ffd16c58bcdf27464d6
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/zephyr/+/4905558
Reviewed-by: Al Semjonovs <asemjonovs@google.com>
Reviewed-by: Fabio Baltieri <fabiobaltieri@google.com>
Commit-Queue: Fabio Baltieri <fabiobaltieri@google.com>
Tested-by: Fabio Baltieri <fabiobaltieri@google.com>
Tested-by: ChromeOS Prod (Robot) <chromeos-ci-prod@chromeos-bot.iam.gserviceaccount.com>
Tested-by: Al Semjonovs <asemjonovs@google.com>
@alexstanoev-nordic alexstanoev-nordic mentioned this pull request Oct 25, 2023
Merged
ldenefle pushed a commit to ldenefle/zephyr that referenced this pull request Nov 1, 2023
@nordicjm
[nrf fromtree] drivers: serial: serial_test: Move ring buf dep to Kco…
4748e5e 
…nfig

This commit moves the dependency management between the
RING_BUFFER and UART_ASYNC_API or UART_INTERRUPT_DRIVEN
options to the Kconfig Kconfig.test.

If either UART API options listed are selected, the
RING_BUFFER option must be selected. This is now handled
automatically by Kconfig instead of causing a build
assert.

The asserts where added with this PR zephyrproject-rtos#59880, and are
removed in this commit.

Signed-off-by: Bjarki Arge Andreasen <baa@trackunit.com>
(cherry picked from commit d118d19)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhedberg jhedberg jhedberg approved these changes

@carlescufi carlescufi carlescufi approved these changes

@jori-nordic jori-nordic jori-nordic approved these changes

@theob-pro theob-pro Awaiting requested review from theob-pro

@nashif nashif Awaiting requested review from nashif

@Vudentz Vudentz Awaiting requested review from Vudentz

@sjanc sjanc Awaiting requested review from sjanc

@galak galak Awaiting requested review from galak

@MaureenHelm MaureenHelm Awaiting requested review from MaureenHelm

@str4t0m str4t0m Awaiting requested review from str4t0m

@asbjornsabo asbjornsabo Awaiting requested review from asbjornsabo

@hermabe hermabe Awaiting requested review from hermabe

@Thalley Thalley Awaiting requested review from Thalley

@dcpleung dcpleung Awaiting requested review from dcpleung

@cvinayak cvinayak Awaiting requested review from cvinayak

@nordic-krch nordic-krch Awaiting requested review from nordic-krch

Assignees

@jhedberg jhedberg

Labels
area: Bluetooth area: Devicetree Binding PR modifies or adds a Device Tree binding area: UART Universal Asynchronous Receiver-Transmitter
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@alwa-nordic @dcpleung @carlescufi @jhedberg @cvinayak @nordic-krch @jori-nordic @zephyrbot