Add Android support #291
Add Android support #291
Conversation
hakonschia
force-pushed
the
android-expressive
branch
from
b4a486f
to
6b22d5a
Compare
README.md
Outdated
|
|
||
| ### Usage | ||
|
|
||
| This library makes it easy to use expressive variants of the icons. See also the [demo app](/android/app/src/main/kotlin/no/nrk/core/icons/MainActivity.kt). |
There was a problem hiding this comment.
Only expressive variants?
There was a problem hiding this comment.
A bit poorly written, I can see how it sounds like only expressive variants are included. Maybe this is better?
This library makes it easy to use NRK icons, as well as automatically changing to expressive variants?
There was a problem hiding this comment.
If I've understood the intent, possibly something in the lines of (...) as well as providing utility to switch between expressive and regular icon variants of the same icon (globally)?
|
Veldig kult, tenker det er gunstig med en notis om android under f.eks. installation på docs i static som tegnes fra |
android/app/proguard-rules.pro
Outdated
|
|
||
| # If you keep the line number information, uncomment this to | ||
| # hide the original source file name. | ||
| #-renamesourcefileattribute SourceFile |
There was a problem hiding this comment.
Possible nitpick, but can this file be formatted according to editorconfig for newline?
There was a problem hiding this comment.
This is just an autogenerated file that isn't really in use, I'll delete it
package.json
Outdated
| @@ -104,5 +104,8 @@ | |||
| "repository": { | |||
| "type": "git", | |||
| "url": "git+https://github.com/nrkno/core-icons.git" | |||
| }, | |||
| "dependencies": { | |||
| "svg2vectordrawable": "^2.9.1" | |||
There was a problem hiding this comment.
Please lock this to an explicit version using npm i -E svg2vectordrawable (lockfile should update too) to avoid possible different versions being used to build, between two unrelated commits to master.
…id Studio, but better safe than sorry
Ikoner blir nå parset fra SVGer til Android drawables så vi i Android verdenen lettere kan bruke ikoner rett fra core-icons. Dette er spesielt for å enkelt kunne bruke ekspressive varianter for barneprofiler i NRK TV
Scriptet kjøres på endringer på
masterog publisher en pakke til Github packagesSe README eller
MainActivityfor hvordan man kan bruke ikonene, eller se på branchenfeature/expressive-icons-v2i TV