Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Live Status Gateway, R51 backport to R50 (SOFIE-3119) #1186

Closed
wants to merge 80 commits into from

Conversation

nytamin
Copy link
Contributor

@nytamin nytamin commented May 7, 2024

About the Contributor

This pull request is posted on behalf of the NRK

Type of Contribution

This is a:

Work-in-Progress PR for a particular need for the R51 features of Live Status Gateway, backported onto R50. Used by NRK.

This is a copy of the live-status-gateway package from R51 branch, as well as the minimum modifications needed to build & be compatible with R50 types and publications
@nytamin nytamin changed the title fix(GUI): remove Piece dependency for Part duration calculation Feat: Live Status Gateway, R51 backport to R50 (SOFIE-3119) May 7, 2024
Copy link

codecov bot commented May 7, 2024

Codecov Report

Attention: Patch coverage is 32.56705% with 352 lines in your changes missing coverage. Please review.

Project coverage is 57.95%. Comparing base (c48a483) to head (e72bda8).
Report is 28 commits behind head on release50.

Files with missing lines Patch % Lines
meteor/lib/MeteorApply.ts 36.00% 96 Missing ⚠️
...r/api/deviceTriggers/StudioDeviceTriggerManager.ts 4.16% 69 Missing ⚠️
meteor/server/publications/rundown.ts 0.00% 49 Missing ⚠️
meteor/server/api/rest/koa.ts 15.15% 28 Missing ⚠️
packages/corelib/src/error.ts 61.29% 12 Missing ⚠️
meteor/lib/api/triggers/MountedTriggers.ts 0.00% 11 Missing ⚠️
packages/job-worker/src/peripheralDevice.ts 10.00% 9 Missing ⚠️
meteor/lib/api/triggers/actionFactory.ts 12.50% 7 Missing ⚠️
packages/shared-lib/src/lib/stringifyError.ts 68.18% 7 Missing ⚠️
...eor/client/ui/Prompter/controller/joycon-device.ts 0.00% 6 Missing ⚠️
... and 22 more
Additional details and impacted files
@@              Coverage Diff              @@
##           release50    #1186      +/-   ##
=============================================
- Coverage      58.11%   57.95%   -0.16%     
=============================================
  Files            483      485       +2     
  Lines          79523    79978     +455     
  Branches        4115     3603     -512     
=============================================
+ Hits           46214    46352     +138     
- Misses         33253    33601     +348     
+ Partials          56       25      -31     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Julusian Julusian changed the base branch from release51 to release50 May 7, 2024 14:19
@jstarpl jstarpl changed the title Feat: Live Status Gateway, R51 backport to R50 (SOFIE-3119) feat: Live Status Gateway, R51 backport to R50 (SOFIE-3119) May 15, 2024
nytamin and others added 20 commits May 16, 2024 07:47
…ons SOFIE-3136

chore: update documentation
fix: ensure that Shift register Ids are only positive integers
fix: test
feat(Device Triggers): add support for setting shift register operations
Co-authored-by: Jan Starzak <jan.starzak@gmail.com>
nytamin and others added 29 commits June 19, 2024 13:46
A local test shows that stringifying messages infividually for each recipient cand easilly take several milliseconds.
…age-performance

Fix: live status gateway send message performance
Fix: live status gateway settings not used
…le-missing

fix(LSG): Token "examples" does not exist when running `yarn gendocs`
fix: make stringifyError handle UserError better (SOFIE-3337)
Because the input type is any we should not treat this as an error, but instead a warning.
…d R joycon … (#1231)

* feat: allows to cofigure an offset-factor between the L and R joycon joysticks to compensate for different rates.

New URL param is called joycon_rightHandOffset. Used to be hardcoded to 1.4 which now is a default.

(cherry picked from commit 9d186ae)

* feat: adds docs
@nytamin nytamin closed this Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants