Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Package containter statuses #577

Merged
merged 10 commits into from
Sep 24, 2021
Merged

Conversation

nytamin
Copy link
Contributor

@nytamin nytamin commented Sep 20, 2021

This PR adds API methods, a new collection and GUI for tracking the status of PackageContainers.

image

@codecov-commenter
Copy link

codecov-commenter commented Sep 20, 2021

Codecov Report

Merging #577 (4090099) into release37 (ab7536a) will decrease coverage by 1.26%.
The diff coverage is 30.86%.

❗ Current head 4090099 differs from pull request most recent head 45d2c07. Consider uploading reports for the commit 45d2c07 to get more accurate results
Impacted file tree graph

@@              Coverage Diff              @@
##           release37     #577      +/-   ##
=============================================
- Coverage      67.50%   66.23%   -1.27%     
=============================================
  Files            261      250      -11     
  Lines          17825    16940     -885     
  Branches        4034     3647     -387     
=============================================
- Hits           12032    11221     -811     
+ Misses          5752     5679      -73     
+ Partials          41       40       -1     
Impacted Files Coverage Δ
meteor/lib/api/rundownLayouts.ts 60.00% <0.00%> (ø)
meteor/lib/collections/BucketAdlibActions.ts 100.00% <ø> (ø)
...r/lib/collections/PackageContainerPackageStatus.ts 77.77% <ø> (ø)
meteor/lib/collections/lib.ts 46.30% <0.00%> (-3.97%) ⬇️
meteor/server/api/peripheralDevice.ts 70.25% <0.00%> (-0.75%) ⬇️
meteor/server/api/userActions.ts 37.94% <0.00%> (-0.52%) ⬇️
meteor/server/api/playout/adlib.ts 28.61% <7.84%> (-1.32%) ⬇️
meteor/server/api/integration/expectedPackages.ts 15.15% <10.71%> (-1.20%) ⬇️
meteor/server/api/snapshot.ts 26.27% <25.00%> (+0.07%) ⬆️
meteor/server/migration/1_37_0.ts 50.00% <26.31%> (-8.50%) ⬇️
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab7536a...45d2c07. Read the comment docs.

@nytamin nytamin marked this pull request as ready for review September 20, 2021 12:50
Copy link
Member

@jstarpl jstarpl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, though I would suggest using Function components for the GUI, since their operation is reasonably straightforward.

meteor/client/ui/Status/StatusCodePill.tsx Outdated Show resolved Hide resolved
meteor/client/ui/Status/package-status/package-status.scss Outdated Show resolved Hide resolved
@nytamin
Copy link
Contributor Author

nytamin commented Sep 23, 2021

I've refactored to use function-components and react hooks instead, good points @jstarpl !

meteor/server/api/userActions.ts Outdated Show resolved Hide resolved
meteor/server/api/packageManager.ts Outdated Show resolved Hide resolved
@github-actions
Copy link

⚡ Published prerelease version server-core-integration@1.37.0-nightly-feat-package-containter-statuses-20210924-070255-7d86479.0 to NPM

@github-actions
Copy link

⚡ Published prerelease version blueprints-integration@1.37.0-nightly-feat-package-containter-statuses-20210924-070255-7d86479.0 to NPM

@nytamin nytamin merged commit b7c3ed5 into release37 Sep 24, 2021
@nytamin nytamin deleted the feat/package-containter-statuses branch September 24, 2021 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants