Release 51 #989
Open
Release 51 #989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #989 +/- ##
==========================================
- Coverage 59.07% 58.07% -1.01%
==========================================
Files 473 522 +49
Lines 71616 84278 +12662
Branches 3725 3019 -706
==========================================
+ Hits 42310 48943 +6633
- Misses 29259 35330 +6071
+ Partials 47 5 -42 ☔ View full report in Codecov by Sentry. |
...by removing an "optimization" that fetched the `privateData` in the rest API's `executeAdLib`, which behaved differently from the Meteor API
…t SOFIE-2887 This is to catch cases where the blueprints define a dependency on a 'new' expectedPackage A, which already exists in the database so can be immediately fulfilled.
… the `replacePart` method signature
…kages-change fix: check if segment should be immediately regenerated during ingest SOFIE-2887
…se51 feat(live-status-gw): expose pieces and split adlibs to a separate topic
feat: a11y improvements
fix: rename 'onPresenterScreen' description in GUI
…age-performance Fix: live status gateway send message performance
Fix: live status gateway settings not used
…le-missing fix(LSG): Token "examples" does not exist when running `yarn gendocs`
(cherry picked from commit a0ea9b4)
fix: Virtual Element (sofie-3264)
(cherry picked from commit bf81baf)
…SOFIE-3305 Pieces are deleted by setting them to `null`, so a `.has` check will match deleted pieces which is not desired
fix: make stringifyError handle UserError better (SOFIE-3337)
# Conflicts: # meteor/package.json # meteor/yarn.lock # packages/blueprints-integration/package.json # packages/corelib/package.json # packages/documentation/package.json # packages/job-worker/package.json # packages/lerna.json # packages/live-status-gateway/package.json # packages/mos-gateway/package.json # packages/openapi/package.json # packages/playout-gateway/package.json # packages/server-core-integration/package.json # packages/shared-lib/package.json # packages/yarn.lock
# Conflicts: # packages/live-status-gateway/api/schemas/adLibs.yaml # packages/live-status-gateway/src/collections/pieceInstancesHandler.ts # packages/live-status-gateway/src/coreHandler.ts
Because they will fail due to SonarCloud not supporting running on external PRs anyway.
SonarCloud skip on external prs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
What is the current behavior? (You can also link to an open issue here)
What is the new behavior (if this is a feature change)?
Other information:
Status