Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: create adlib testing rundowns SOFIE-2963 #1211

Merged
merged 21 commits into from
Jun 25, 2024

Conversation

Julusian
Copy link
Member

@Julusian Julusian commented Jun 21, 2024

About the Contributor

This pull request is posted on behalf of the NRK.

Type of Contribution

This is a: Feature

New Behavior

This adds support for having buttons on the rundown list page, to create empty rundowns to be used with the 'adlib testing' mode.
The buttons to add the rundowns are only shown to studio level users, and they can also see the delete button to remove them

A blueprint method has been added generateTestingRundown which allows the blueprints to define the IngestRundown that should be used, if not implemented then sofie will fallback to using a minimal empty rundown.

Support for generating these rundowns has to be enabled on each show style variant that wants it, making this be opt-in and not visible for installations where not explicitly enabled.

UX isn't amazing, this can be refined with further iterations
image

This builds upon #1210, which allows for the 'reload nrcs data' to re-run the create operation to regenerate the rundown including blueprint defined ingest data.

Testing

  • I have added one or more unit tests for this PR
  • I have updated the relevant unit tests
  • No unit test changes are needed for this PR

Affected areas

Time Frame

Other Information

Status

  • PR is ready to be reviewed.
  • The functionality has been tested by the author.
  • Relevant unit tests has been added / updated.
  • Relevant documentation (code comments, system documentation) has been added / updated.

Copy link

codecov bot commented Jun 21, 2024

Codecov Report

Attention: Patch coverage is 57.97101% with 116 lines in your changes missing coverage. Please review.

Project coverage is 58.01%. Comparing base (8f8d147) to head (6fbcfea).
Report is 424 commits behind head on release51.

Files Patch % Lines
meteor/server/api/showStyles.ts 8.45% 65 Missing ⚠️
meteor/server/api/ingest/actions.ts 7.50% 37 Missing ⚠️
...ackages/job-worker/src/ingest/ingestRundownJobs.ts 63.15% 7 Missing ⚠️
meteor/lib/clientUserAction.ts 0.00% 2 Missing ⚠️
...ackages/job-worker/src/ingest/ingestSegmentJobs.ts 60.00% 2 Missing ⚠️
packages/job-worker/src/rundown.ts 50.00% 1 Missing and 1 partial ⚠️
.../job-worker/src/ingest/mosDevice/mosRundownJobs.ts 66.66% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##           release51    #1211      +/-   ##
=============================================
- Coverage      58.01%   58.01%   -0.01%     
=============================================
  Files            484      523      +39     
  Lines          79686    84704    +5018     
  Branches        4053     4418     +365     
=============================================
+ Hits           46233    49139    +2906     
- Misses         33417    35539    +2122     
+ Partials          36       26      -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Julusian Julusian force-pushed the feat/create-testing-rundown branch from fd732c6 to 1369edc Compare June 21, 2024 13:10
@Julusian Julusian changed the title feat: create adlib testing rundowns feat: create adlib testing rundowns SOFIE-2963 Jun 21, 2024
@Julusian Julusian marked this pull request as ready for review June 21, 2024 14:03
@Julusian Julusian requested a review from a team as a code owner June 21, 2024 14:03
meteor/client/ui/RundownList/CreateTestingRundownPanel.tsx Outdated Show resolved Hide resolved
meteor/client/ui/RundownList.tsx Outdated Show resolved Hide resolved
packages/job-worker/src/ingest/ingestRundownJobs.ts Outdated Show resolved Hide resolved
Base automatically changed from feat/rundown-source to release51 June 24, 2024 12:54
@Julusian Julusian force-pushed the feat/create-testing-rundown branch from 1d9b0af to 06ed677 Compare June 24, 2024 12:59
@Julusian Julusian requested a review from nytamin June 24, 2024 13:03
@Julusian Julusian merged commit a831989 into release51 Jun 25, 2024
77 of 80 checks passed
@Julusian Julusian deleted the feat/create-testing-rundown branch June 25, 2024 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants