-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: create adlib testing rundowns SOFIE-2963 #1211
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release51 #1211 +/- ##
=============================================
- Coverage 58.01% 58.01% -0.01%
=============================================
Files 484 523 +39
Lines 79686 84704 +5018
Branches 4053 4418 +365
=============================================
+ Hits 46233 49139 +2906
- Misses 33417 35539 +2122
+ Partials 36 26 -10 ☔ View full report in Codecov by Sentry. |
Julusian
force-pushed
the
feat/rundown-source
branch
from
June 21, 2024 13:09
df3b505
to
f60f5e7
Compare
Julusian
force-pushed
the
feat/create-testing-rundown
branch
from
June 21, 2024 13:10
fd732c6
to
1369edc
Compare
Julusian
changed the title
feat: create adlib testing rundowns
feat: create adlib testing rundowns SOFIE-2963
Jun 21, 2024
nytamin
requested changes
Jun 24, 2024
Julusian
force-pushed
the
feat/create-testing-rundown
branch
from
June 24, 2024 12:59
1d9b0af
to
06ed677
Compare
nytamin
approved these changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the Contributor
This pull request is posted on behalf of the NRK.
Type of Contribution
This is a: Feature
New Behavior
This adds support for having buttons on the rundown list page, to create empty rundowns to be used with the 'adlib testing' mode.
The buttons to add the rundowns are only shown to studio level users, and they can also see the delete button to remove them
A blueprint method has been added
generateTestingRundown
which allows the blueprints to define theIngestRundown
that should be used, if not implemented then sofie will fallback to using a minimal empty rundown.Support for generating these rundowns has to be enabled on each show style variant that wants it, making this be opt-in and not visible for installations where not explicitly enabled.
UX isn't amazing, this can be refined with further iterations
This builds upon #1210, which allows for the 'reload nrcs data' to re-run the create operation to regenerate the rundown including blueprint defined ingest data.
Testing
Affected areas
Time Frame
Other Information
Status