This repository has been archived by the owner on Aug 11, 2023. It is now read-only.
Feat: Copy files removed from target in WatchFolder flow #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should be 2 PRs.
|
sparkpunkd
suggested changes
Feb 18, 2021
There was a problem hiding this comment.
This PR has been hanging around for a while. The request to split into 2 was never actionned. And the fix to change "targetID" to "destinationId" has been in for 5 months now.
If this feature still required? If so, I have retargetted at Release 31. The world has moved on the the checkAndEmitCopyFunction has been reworked. This PR contains what appears to be a copy and paste of that function from the expectedItemsGenerator ... a bad code smell. So although this PR would merge into R31, I would like to see some consideration of code sharing between the expectedItemsGenerator and the watchFolderGenerator.
If no longer required, please close the PR.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an optional cron job feature to WatchFolder flow, that periodically checks for files that are missing on the target storage but are still present on the source storage, and issues a workflow to copy them.
Option can be enabled per flow, in its settings.