fix(core): attach cli args from target options explicitly with '=' (#…

…22756)
nrwl · Apr 9, 2024 · 0548871 · 0548871
1 parent 9f3d305
commit 0548871
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/e2e/nx-misc/src/extras.test.ts b/e2e/nx-misc/src/extras.test.ts
@@ -165,7 +165,7 @@ describe('Extra Nx Misc Tests', () => {
       });
 
       const result = runCLI(`run ${mylib}:echo`, { silent: true });
-      expect(result).toContain('--var1 a');
+      expect(result).toContain('--var1=a');
     }, 120000);
 
     it('should interpolate provided arguments', async () => {

diff --git a/packages/nx/src/executors/run-commands/run-commands.impl.spec.ts b/packages/nx/src/executors/run-commands/run-commands.impl.spec.ts
@@ -238,7 +238,7 @@ describe('Run Commands', () => {
           { unknownOptions: { hello: 123 }, parsedArgs: { hello: 123 } } as any,
           true
         )
-      ).toEqual('echo --hello 123');
+      ).toEqual('echo --hello=123');
     });
 
     it('should add all args and unparsed args when forwardAllArgs is true', () => {

diff --git a/packages/nx/src/executors/run-commands/run-commands.impl.ts b/packages/nx/src/executors/run-commands/run-commands.impl.ts
@@ -486,7 +486,7 @@ export function interpolateArgsIntoCommand(
               typeof opts.unknownOptions[k] !== 'object' &&
               opts.parsedArgs[k] === opts.unknownOptions[k]
           )
-          .map((k) => `--${k} ${opts.unknownOptions[k]}`)
+          .map((k) => `--${k}=${opts.unknownOptions[k]}`)
           .join(' ');
     }
     if (opts.args) {