Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): attach cli args from target options explicitly with '=' #22756

Merged
merged 1 commit into from Apr 9, 2024

Conversation

Coly010
Copy link
Contributor

@Coly010 Coly010 commented Apr 9, 2024

Current Behavior

When attaching options from targets for run-commands we attach the value with a space:

"build": {
   "options": {
       "sourcemap": true
   }
}

becomes
--sourcemap true

This causes some CLI tools to fail when parsing.

Expected Behavior

Attach the option with =

The above target becomes
--sourcemap=true

image

Related Issue(s)

Fixes #

@Coly010 Coly010 requested a review from a team as a code owner April 9, 2024 20:33
@Coly010 Coly010 self-assigned this Apr 9, 2024
Copy link

vercel bot commented Apr 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Apr 9, 2024 9:33pm

@Coly010 Coly010 force-pushed the run-commands-attach-cli-explicitly branch from acaa55e to bda8835 Compare April 9, 2024 21:32
@Coly010 Coly010 merged commit 0548871 into nrwl:master Apr 9, 2024
6 checks passed
@Coly010 Coly010 deleted the run-commands-attach-cli-explicitly branch April 9, 2024 22:25
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants