Skip to content

Commit

Permalink
fix(react): skip exports field in generated package.json when using r…
Browse files Browse the repository at this point in the history
…ollup to bundle library (#14107)
  • Loading branch information
jaysoo committed Jan 3, 2023
1 parent 16a0891 commit 666e057
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 10 deletions.
Original file line number Diff line number Diff line change
@@ -1,12 +1,4 @@
{
"name": "<%= name %>",
"version": "0.0.1",
"main": "./index.js",
"module": "./index.mjs",
"exports": {
".": {
"import": "./index.mjs",
"require": "./index.js"
}
}
"version": "0.0.1"
}
2 changes: 2 additions & 0 deletions packages/rollup/src/generators/init/init.spec.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import { Tree, readJson, NxJsonConfiguration, updateJson } from '@nrwl/devkit';
import { createTreeWithEmptyWorkspace } from '@nrwl/devkit/testing';
import { nxVersion } from '../../utils/versions';

import { rollupInitGenerator } from './init';

Expand Down Expand Up @@ -35,6 +36,7 @@ describe('rollupInitGenerator', () => {
name: expect.any(String),
dependencies: {},
devDependencies: {
'@nrwl/rollup': nxVersion,
'@swc/helpers': expect.any(String),
'@swc/core': expect.any(String),
'swc-loader': expect.any(String),
Expand Down
7 changes: 6 additions & 1 deletion packages/rollup/src/generators/init/init.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,11 @@ import {
} from '@nrwl/devkit';
import { Schema } from './schema';
import { swcCoreVersion, swcHelpersVersion } from '@nrwl/js/src/utils/versions';
import { swcLoaderVersion, tsLibVersion } from '../../utils/versions';
import {
nxVersion,
swcLoaderVersion,
tsLibVersion,
} from '../../utils/versions';
import { addBabelInputs } from '@nrwl/js/src/utils/add-babel-inputs';

export async function rollupInitGenerator(tree: Tree, schema: Schema) {
Expand All @@ -22,6 +26,7 @@ export async function rollupInitGenerator(tree: Tree, schema: Schema) {
tree,
{},
{
'@nrwl/rollup': nxVersion,
'@swc/helpers': swcHelpersVersion,
'@swc/core': swcCoreVersion,
'swc-loader': swcLoaderVersion,
Expand Down

0 comments on commit 666e057

Please sign in to comment.