Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react): skip exports field in generated package.json when using rollup to bundle library #14107

Merged
merged 1 commit into from
Jan 3, 2023

Conversation

jaysoo
Copy link
Member

@jaysoo jaysoo commented Jan 3, 2023

This PR reverts generated package.json to not include exports, module, and main fields since these are generated dynamically by @nrwl/rollup:rollup executor.

Also adds @nrwl/rollup install to @nrwl/rollup:init generator which was missing previously.

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #14063

@vercel
Copy link

vercel bot commented Jan 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
nx-dev ⬜️ Ignored (Inspect) Jan 3, 2023 at 2:24PM (UTC)

@jaysoo jaysoo requested a review from mandarini January 3, 2023 14:07
@jaysoo jaysoo changed the title fix(react): skip exports field in generated package.json when using r… fix(react): skip exports field in generated package.json when using rollup to bundle library Jan 3, 2023
@mandarini mandarini merged commit 666e057 into nrwl:master Jan 3, 2023
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken output for react libraries using rollup
2 participants