Skip to content

Commit

Permalink
feat(nx-cloud): restore version of open
Browse files Browse the repository at this point in the history
  • Loading branch information
mandarini committed Jun 18, 2024
1 parent 40aab82 commit 848b0be
Show file tree
Hide file tree
Showing 5 changed files with 7 additions and 7 deletions.
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -232,7 +232,7 @@
"nuxt": "^3.10.0",
"nx": "19.2.0-rc.0",
"octokit": "^2.0.14",
"open": "^10.1.0",
"open": "^8.4.0",
"openai": "~4.3.1",
"ora": "5.3.0",
"parse-markdown-links": "^1.0.4",
Expand Down
2 changes: 1 addition & 1 deletion packages/nx/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@
"lines-and-columns": "~2.0.3",
"minimatch": "9.0.3",
"npm-run-path": "^4.0.1",
"open": "^10.1.0",
"open": "^8.4.0",
"semver": "^7.5.3",
"string-width": "^4.2.3",
"strong-log-transformer": "^2.1.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/nx/src/command-line/graph/graph.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import { copySync, ensureDirSync } from 'fs-extra';
import * as http from 'http';
import { minimatch } from 'minimatch';
import { URL } from 'node:url';
import * as open from 'open';
import {
basename,
dirname,
Expand Down Expand Up @@ -525,7 +526,6 @@ export async function generateGraph(
});

if (args.open) {
const open = require('open');
open(url.toString());
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import { readNxJson, updateNxJson } from '../../../generators/utils/nx-json';
import { formatChangedFilesWithPrettierIfAvailable } from '../../../generators/internal-utils/format-changed-files-with-prettier-if-available';
import { repoUsesGithub, shortenedCloudUrl } from '../../utilities/url-shorten';
import * as ora from 'ora';
import * as open from 'open';

function printCloudConnectionDisabledMessage() {
output.error({
Expand Down Expand Up @@ -106,8 +107,7 @@ async function printSuccessMessage(
const cloudConnectSpinner = ora(
`Opening Nx Cloud in your browser to connect your workspace.`
).start();
await sleep(3000);
const open = require('open');
await sleep(2000);
open(connectCloudUrl);
cloudConnectSpinner.stop();
} catch (e) {
Expand Down
4 changes: 2 additions & 2 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 848b0be

Please sign in to comment.