fix(angular): don't share angular mfe package

nrwl · Apr 29, 2022 · af0cfd4 · af0cfd4
1 parent 3abff91
commit af0cfd4
Showing 1 changed file with 9 additions and 7 deletions.
diff --git a/packages/angular/src/utils/mfe/with-module-federation.ts b/packages/angular/src/utils/mfe/with-module-federation.ts
@@ -4,10 +4,10 @@ import {
   shareWorkspaceLibraries,
 } from './mfe-webpack';
 import {
-  workspaceRoot,
   createProjectGraphAsync,
   ProjectGraph,
   readCachedProjectGraph,
+  workspaceRoot,
   Workspaces,
 } from '@nrwl/devkit';
 import {
@@ -151,18 +151,20 @@ function mapRemotes(remotes: MFERemotes) {
 }
 
 export async function withModuleFederation(options: MFEConfig) {
-  const DEFAULT_NPM_PACKAGES_TO_AVOID = ['zone.js'];
+  const DEFAULT_NPM_PACKAGES_TO_AVOID = ['zone.js', '@nrwl/angular/mfe'];
 
   const dependencies = await getDependentPackagesForProject(options.name);
   const sharedLibraries = shareWorkspaceLibraries(
     dependencies.workspaceLibraries
   );
 
-  const npmPackages = sharePackages(
-    dependencies.npmPackages.filter(
-      (pkg) => !DEFAULT_NPM_PACKAGES_TO_AVOID.includes(pkg)
-    )
-  );
+  const npmPackages = sharePackages(dependencies.npmPackages);
+
+  DEFAULT_NPM_PACKAGES_TO_AVOID.forEach((pkgName) => {
+    if (pkgName in npmPackages) {
+      delete npmPackages[pkgName];
+    }
+  });
 
   const sharedDependencies = {
     ...sharedLibraries.getLibraries(),