fix(storybook): fix schema to read projectName from config #11098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
mandarini
force-pushed
the
fix/dropdown-projectname-storybook
branch
from
b5cc818
to
bacc548
Compare
packages/react-native/src/generators/storybook-configuration/schema.json
Outdated
Show resolved
Hide resolved
mandarini
force-pushed
the
fix/dropdown-projectname-storybook
branch
from
bacc548
to
5e4167c
Compare
mandarini
force-pushed
the
fix/dropdown-projectname-storybook
branch
from
5e4167c
to
2825866
Compare
leosvelperez
requested changes
Jul 11, 2022
packages/angular/src/generators/storybook-configuration/schema.json
Outdated
Show resolved
Hide resolved
packages/react-native/src/generators/component-story/schema.json
Outdated
Show resolved
Hide resolved
packages/react-native/src/generators/storybook-configuration/schema.json
Outdated
Show resolved
Hide resolved
packages/react/src/generators/storybook-configuration/schema.json
Outdated
Show resolved
Hide resolved
mandarini
force-pushed
the
fix/dropdown-projectname-storybook
branch
from
2825866
to
79502bd
Compare
mandarini
force-pushed
the
fix/dropdown-projectname-storybook
branch
from
79502bd
to
b8f1b5f
Compare
mandarini
force-pushed
the
fix/dropdown-projectname-storybook
branch
from
b8f1b5f
to
a2d0060
Compare
AgentEnder
approved these changes
Jul 12, 2022
FrozenPandaz
pushed a commit
that referenced
this pull request
Jul 15, 2022
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
The storybook-related generators do not provide a dropdown for project names, at the moment. This is due to the fact that the parameter that is used to submit the project is named
name, and the default is not provided correctly.Expected Behavior
There should be a drop down of project names.
I changed the
defaultsource to beprojectName. I also added prompts where there were not.