Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react): fix path to CT tsconfig #13177

Merged
merged 1 commit into from
Dec 2, 2022

Conversation

danr-za
Copy link
Contributor

@danr-za danr-za commented Nov 15, 2022

Current Behavior

The component test preset in React is looking for tsconfig.cy.json in the root project directory, but the generator creates it under cypress folder.

Expected Behavior

Should look for it in the generated path

Related Issue(s)

Fixes #

@vercel
Copy link

vercel bot commented Nov 15, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
nx-dev ⬜️ Ignored (Inspect) Nov 15, 2022 at 3:58PM (UTC)

Copy link
Contributor

@barbados-clemens barbados-clemens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just ran into this myself 🤦 thanks for fixing!

@barbados-clemens barbados-clemens merged commit 3e2b8d9 into nrwl:master Dec 2, 2022
@danr-za danr-za deleted the fix/react-cypress-ct-ts-path branch December 3, 2022 17:15
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants