Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): support targets with colons in the name without quotes #13938

Merged
merged 4 commits into from
Dec 28, 2022
Merged

feat(core): support targets with colons in the name without quotes #13938

merged 4 commits into from
Dec 28, 2022

Conversation

AgentEnder
Copy link
Member

See #13914

@vercel
Copy link

vercel bot commented Dec 20, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
nx-dev ✅ Ready (Inspect) Visit Preview Dec 28, 2022 at 7:53PM (UTC)

@nx-cloud
Copy link

nx-cloud bot commented Dec 20, 2022 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 705e62f. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 12 targets

Sent with 💌 from NxCloud.

@AgentEnder AgentEnder force-pushed the fix/better-support-for-colons-in-target-names branch from 80833cd to bde472f Compare December 20, 2022 21:27
@AgentEnder AgentEnder force-pushed the fix/better-support-for-colons-in-target-names branch from bde472f to 9bfcfa8 Compare December 20, 2022 22:49
FrozenPandaz
FrozenPandaz previously requested changes Dec 20, 2022
View reviewed changes
docs/generated/devkit/index.md Outdated Show resolved Hide resolved
packages/angular/src/builders/webpack-dev-server/webpack-dev-server.impl.ts
const parsedBrowserTarget = parseTargetString(options.browserTarget);
const parsedBrowserTarget = parseTargetString(
options.browserTarget,
readCachedProjectGraph()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
readCachedProjectGraph()
context.projectGraph

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't exist in this one... Its an angular builder.

...gular/src/migrations/update-12-3-0/convert-webpack-browser-build-target-to-delegate-build.ts Outdated Show resolved Hide resolved
...gular/src/migrations/update-12-3-0/convert-webpack-browser-build-target-to-delegate-build.ts Outdated Show resolved Hide resolved
packages/cypress/src/migrations/update-15-0-0/update-cy-mount-usage.ts Outdated Show resolved Hide resolved
packages/nx/src/project-graph/project-graph-builder.ts Outdated Show resolved Hide resolved
packages/nx/src/utils/split-target.spec.ts Outdated Show resolved Hide resolved
packages/react/src/generators/cypress-component-configuration/lib/add-files.ts Outdated Show resolved Hide resolved
packages/storybook/src/generators/configuration/util-functions.ts Outdated Show resolved Hide resolved
packages/workspace/src/generators/remove/lib/check-targets.ts Outdated Show resolved Hide resolved
@AgentEnder AgentEnder force-pushed the fix/better-support-for-colons-in-target-names branch from bf81b6a to 874d214 Compare December 22, 2022 21:50
@AgentEnder AgentEnder force-pushed the fix/better-support-for-colons-in-target-names branch from 874d214 to 475d2ec Compare December 22, 2022 22:39
vsavkin
vsavkin approved these changes Dec 28, 2022
View reviewed changes
Copy link
Member

@vsavkin vsavkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change is good. Two small things:

  • We should not change the interface of a core object just for tests.
  • Loops in tests is a bad idea.

packages/nx/src/project-graph/project-graph-builder.ts Outdated
@@ -28,7 +28,7 @@ export class ProjectGraphBuilder {
/**
* Adds a project node to the project graph
*/
addNode(node: ProjectGraphProjectNode): void {
addNode<T extends ProjectGraphProjectNode>(node: T) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this required ?

packages/nx/src/utils/split-target.spec.ts Outdated
@@ -1,14 +1,44 @@
import { ProjectGraph, ProjectGraphProjectNode } from '../config/project-graph';
import { ProjectConfiguration } from '../config/workspace-json-project-json';
import { ProjectGraphBuilder } from '../project-graph/project-graph-builder';
import { splitTarget } from './split-target';

const cases = [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove the loop. inline everything.

@AgentEnder AgentEnder enabled auto-merge (squash) December 28, 2022 19:45
@AgentEnder AgentEnder merged commit 285dc39 into nrwl:master Dec 28, 2022
AgentEnder added a commit to AgentEnder/nx that referenced this pull request Dec 29, 2022
@AgentEnder
feat(core): support targets with colons in the name without quotes (n…
faa9e18 
…rwl#13938)
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vsavkin vsavkin vsavkin approved these changes

@FrozenPandaz FrozenPandaz Awaiting requested review from FrozenPandaz FrozenPandaz is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AgentEnder @vsavkin @FrozenPandaz