-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(testing): support async webpack config for react component testing #14037
Merged
AgentEnder
merged 1 commit into
nrwl:master
from
barbados-clemens:fix/ct-webpack-typings
Dec 28, 2022
Merged
feat(testing): support async webpack config for react component testing #14037
AgentEnder
merged 1 commit into
nrwl:master
from
barbados-clemens:fix/ct-webpack-typings
Dec 28, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
barbados-clemens
force-pushed
the
fix/ct-webpack-typings
branch
from
December 28, 2022 15:04
1a55ccd
to
61bbbb1
Compare
barbados-clemens
force-pushed
the
fix/ct-webpack-typings
branch
from
December 28, 2022 15:11
61bbbb1
to
547ddb6
Compare
barbados-clemens
changed the title
feat(testing): support async webpack config for react
feat(testing): support async webpack config for react component testing
Dec 28, 2022
barbados-clemens
added
the
scope: testing tools
Issues related to Cypress / Jest / Playwright / Vitest support in Nx
label
Dec 28, 2022
barbados-clemens
requested review from
mandarini,
jaysoo,
AgentEnder and
Coly010
December 28, 2022 15:37
AgentEnder
approved these changes
Dec 28, 2022
AgentEnder
pushed a commit
to AgentEnder/nx
that referenced
this pull request
Dec 29, 2022
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
currently component testing doesn't support using an async webpack config
Expected Behavior
component testing allows for using an async webpack config
Related Issue(s)
Note: this is partly motivated via being able to use the module federation webpack setup with CT, but for some reason webpack finishes but cypress never starts. still need to investiagte. but a simple 'async' webpack config works. so there might need to be something extra that is checked for when using module federation with cypress component testing.
Fixes #