Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(testing): support async webpack config for react component testing #14037

Merged
merged 1 commit into from
Dec 28, 2022

Conversation

barbados-clemens
Copy link
Contributor

@barbados-clemens barbados-clemens commented Dec 27, 2022

Current Behavior

currently component testing doesn't support using an async webpack config

Expected Behavior

component testing allows for using an async webpack config

Related Issue(s)

Note: this is partly motivated via being able to use the module federation webpack setup with CT, but for some reason webpack finishes but cypress never starts. still need to investiagte. but a simple 'async' webpack config works. so there might need to be something extra that is checked for when using module federation with cypress component testing.

Fixes #

@vercel
Copy link

vercel bot commented Dec 27, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
nx-dev ⬜️ Ignored (Inspect) Dec 28, 2022 at 3:11PM (UTC)

@nx-cloud
Copy link

nx-cloud bot commented Dec 27, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 547ddb6. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 21 targets

Sent with 💌 from NxCloud.

@barbados-clemens barbados-clemens changed the title feat(testing): support async webpack config for react feat(testing): support async webpack config for react component testing Dec 28, 2022
@barbados-clemens barbados-clemens self-assigned this Dec 28, 2022
@barbados-clemens barbados-clemens added the scope: testing tools Issues related to Cypress / Jest / Playwright / Vitest support in Nx label Dec 28, 2022
@barbados-clemens barbados-clemens marked this pull request as ready for review December 28, 2022 15:38
@AgentEnder AgentEnder merged commit 663d38b into nrwl:master Dec 28, 2022
AgentEnder pushed a commit to AgentEnder/nx that referenced this pull request Dec 29, 2022
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
scope: testing tools Issues related to Cypress / Jest / Playwright / Vitest support in Nx
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants