Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(expo): move svg to inline for starter app #14068

Merged
merged 1 commit into from
Jan 3, 2023

Conversation

xiongemi
Copy link
Collaborator

move svg to inline for starter app for expo and react-native

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #

@vercel
Copy link

vercel bot commented Dec 31, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
nx-dev ⬜️ Ignored (Inspect) Dec 31, 2022 at 7:39AM (UTC)

@xiongemi xiongemi requested a review from jaysoo December 31, 2022 05:31
@nx-cloud
Copy link

nx-cloud bot commented Dec 31, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 365d95d. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


🟥 Failed Commands
nx affected --target=e2e --base=d5c93bfa39c798bc5f594aa85e37a8b0cbe0b44e --head=5bfdd03c49132fb4e322d6c25d0d4b26df3c30f7 --exclude=e2e-make-angular-cli-faster,e2e-detox,e2e-js,e2e-next,e2e-workspace-create,e2e-nx-run,e2e-nx-misc,e2e-react,e2e-web,e2e-webpack,e2e-rollup,e2e-esbuild,e2e-angular-extensions,e2e-angular-core,e2e-nx-plugin,e2e-cypress,e2...
nx affected --target=e2e --base=d5c93bfa39c798bc5f594aa85e37a8b0cbe0b44e --head=5bfdd03c49132fb4e322d6c25d0d4b26df3c30f7 --exclude=e2e-storybook,e2e-storybook-angular,e2e-react-native,e2e-detox --parallel=1
✅ Successfully ran 22 targets

Sent with 💌 from NxCloud.

@xiongemi xiongemi added scope: react-native Issues relating to React Native type: feature labels Dec 31, 2022
@xiongemi xiongemi force-pushed the bugfix/update-svg-react-native branch from a3b2cf6 to 5bfdd03 Compare December 31, 2022 06:09
@xiongemi xiongemi force-pushed the bugfix/update-svg-react-native branch from 5bfdd03 to 365d95d Compare December 31, 2022 07:39
@xiongemi xiongemi merged commit cec625e into master Jan 3, 2023
@xiongemi xiongemi deleted the bugfix/update-svg-react-native branch January 16, 2023 19:38
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
scope: react-native Issues relating to React Native type: feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants