Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(testing): only check provided project is root for cypress-project… #14148

Conversation

barbados-clemens
Copy link
Contributor

… generator

Current Behavior

cypress generating projects in the root directory when provided project is not the root project

Expected Behavior

cypress uses the provided project to determine the if it's the root project

Related Issue(s)

Fixes #14138

@barbados-clemens barbados-clemens added the scope: testing tools Issues related to Cypress / Jest / Playwright / Vitest support in Nx label Jan 4, 2023
@barbados-clemens barbados-clemens self-assigned this Jan 4, 2023
@vercel
Copy link

vercel bot commented Jan 4, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
nx-dev ⬜️ Ignored (Inspect) Jan 4, 2023 at 7:40PM (UTC)

@barbados-clemens barbados-clemens enabled auto-merge (squash) January 4, 2023 19:56
@barbados-clemens barbados-clemens merged commit 49aa44b into nrwl:master Jan 4, 2023
@barbados-clemens barbados-clemens deleted the fix/standalone-cypress-project-checks branch January 4, 2023 20:25
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
scope: testing tools Issues related to Cypress / Jest / Playwright / Vitest support in Nx
Projects
None yet
Development

Successfully merging this pull request may close these issues.

e2e apps generating outside of the apps directory
2 participants