Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(testing): jest 29 support #14701

Merged
merged 13 commits into from
Feb 23, 2023
Merged

feat(testing): jest 29 support #14701

merged 13 commits into from
Feb 23, 2023

Conversation

barbados-clemens
Copy link
Contributor

@barbados-clemens barbados-clemens commented Jan 30, 2023 •
edited
Loading

Current Behavior

nx only supports jest 28

Expected Behavior

nx supports jest 29

Related Issue(s)

TODO:

  • make sure jest-preset-angular@13 works.
  • Wait for Stable v13 release

Fixes #11892

@barbados-clemens barbados-clemens added the scope: testing tools Issues related to Cypress / Jest / Playwright / Vitest support in Nx label Jan 30, 2023
@barbados-clemens barbados-clemens self-assigned this Jan 30, 2023
@vercel
Copy link

vercel bot commented Jan 30, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 23, 2023 at 7:57PM (UTC)

@nx-cloud
Copy link

nx-cloud bot commented Jan 30, 2023 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit d6bab70. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

Coly010
Coly010 reviewed Feb 10, 2023
View reviewed changes
packages/angular/src/utils/versions.ts Outdated Show resolved Hide resolved
packages/jest/migrations.json Outdated Show resolved Hide resolved
meeroslav
meeroslav requested changes Feb 13, 2023
View reviewed changes
Copy link
Contributor

@meeroslav meeroslav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left two questions. Apart from that Linter part looks good to me.

@barbados-clemens barbados-clemens merged commit 8a97b43 into nrwl:master Feb 23, 2023
@barbados-clemens barbados-clemens deleted the feat/jest-29-support branch February 23, 2023 20:37
@github-actions
Copy link

github-actions bot commented Mar 3, 2023

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AgentEnder AgentEnder AgentEnder approved these changes

@FrozenPandaz FrozenPandaz FrozenPandaz approved these changes

@Coly010 Coly010 Coly010 approved these changes

@nartc nartc nartc approved these changes

@vsavkin vsavkin Awaiting requested review from vsavkin vsavkin is a code owner

@jaysoo jaysoo Awaiting requested review from jaysoo jaysoo is a code owner

@ndcunningham ndcunningham Awaiting requested review from ndcunningham

@xiongemi xiongemi Awaiting requested review from xiongemi

@JamesHenry JamesHenry Awaiting requested review from JamesHenry JamesHenry is a code owner

@leosvelperez leosvelperez Awaiting requested review from leosvelperez

@meeroslav meeroslav Awaiting requested review from meeroslav

Assignees

@barbados-clemens barbados-clemens

Labels
scope: testing tools Issues related to Cypress / Jest / Playwright / Vitest support in Nx
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support Jest version 29.x.x
10 participants
@barbados-clemens @kunyan @Coly010 @forivall @minijus @meeroslav @AgentEnder @FrozenPandaz @leosvelperez @nartc