-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core): update ensurePackage util with workaround for bad module cache #14786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
jaysoo
force-pushed
the
fix/ensure-package-typescript
branch
from
February 3, 2023 14:30
b406d7a
to
503f5e6
Compare
jaysoo
force-pushed
the
fix/ensure-package-typescript
branch
from
February 3, 2023 14:44
503f5e6
to
4edbe76
Compare
jaysoo
force-pushed
the
fix/ensure-package-typescript
branch
from
February 3, 2023 16:43
4edbe76
to
57e2d1f
Compare
jaysoo
force-pushed
the
fix/ensure-package-typescript
branch
from
February 3, 2023 16:47
57e2d1f
to
314331c
Compare
jaysoo
force-pushed
the
fix/ensure-package-typescript
branch
from
February 3, 2023 17:08
314331c
to
fc22ccc
Compare
jaysoo
force-pushed
the
fix/ensure-package-typescript
branch
from
February 3, 2023 18:51
fc22ccc
to
b71c118
Compare
jaysoo
force-pushed
the
fix/ensure-package-typescript
branch
from
February 3, 2023 19:14
b71c118
to
c3f048f
Compare
jaysoo
force-pushed
the
fix/ensure-package-typescript
branch
from
February 7, 2023 19:23
c3f048f
to
8edd29f
Compare
jaysoo
force-pushed
the
fix/ensure-package-typescript
branch
from
February 7, 2023 19:52
8edd29f
to
b85f711
Compare
FrozenPandaz
approved these changes
Feb 7, 2023
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current
ensurePackage
function from@nrwl/devkit
fails for some packages liketypescript
due to bad module cache (Note: not require cache, but module/file cache).See the problem here: https://github.com/jaysoo/ts-resolve-pkg
The solution is to avoid
require.resolve
orrequire
when detecting the locally installed package version. Instead, use a sandboxedrequire
fromcreateRequire(...)
to avoid any pollution.Current Behavior
Expected Behavior
Related Issue(s)
Fixes #