fix(core): do not hardcode checks for npm #14827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
AgentEnder
approved these changes
Feb 6, 2023
| // we're only intersted in project dependencies, not npm | ||
| if (dependencyName.startsWith('npm:')) { | ||
| // we're only interested in internal nodes, not external | ||
| if (nxDeps.externalNodes?.[dependencyName]) { |
There was a problem hiding this comment.
We should rename nxDeps -> projectGraph or similar, I thought it was a different data structure at a glance. Either way, thats existing. Feel free to correct now or leave it, it can always be cleaned up a bit later.
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
With project graph plugins, they contain support to add third party deps to the project graph. We have utils that were hard coded to only check if these third party deps started with
npm. This caused issues because third party deps ended up in project depsExpected Behavior
All external nodes will be ignored when trying to get all internal dependent nodes.
Related Issue(s)
Fixes #