-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core): do not hardcode checks for npm #14827
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
// we're only intersted in project dependencies, not npm | ||
if (dependencyName.startsWith('npm:')) { | ||
// we're only interested in internal nodes, not external | ||
if (nxDeps.externalNodes?.[dependencyName]) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should rename nxDeps -> projectGraph or similar, I thought it was a different data structure at a glance. Either way, thats existing. Feel free to correct now or leave it, it can always be cleaned up a bit later.
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Current Behavior
With project graph plugins, they contain support to add third party deps to the project graph. We have utils that were hard coded to only check if these third party deps started with
npm
. This caused issues because third party deps ended up in project depsExpected Behavior
All external nodes will be ignored when trying to get all internal dependent nodes.
Related Issue(s)
Fixes #