Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(graph): show errors from task graph generation #14924

Merged
merged 2 commits into from
Feb 10, 2023

Conversation

philipjfulcher
Copy link
Collaborator

@philipjfulcher philipjfulcher commented Feb 10, 2023

Current Behavior

  • The task graph visualization does not display if there is any trouble generating a task graph for the workspace.

Expected Behavior

  • The task graph generation catches errors and later displays them under a tooltip in the visualization
  • The tooltip is currently wrapped in a feature flag due to some issues with rendering and causing problems when changing targets

@vercel
Copy link

vercel bot commented Feb 10, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 10, 2023 at 10:23PM (UTC)

Copy link
Collaborator

@FrozenPandaz FrozenPandaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI failures are unrelated.

@FrozenPandaz FrozenPandaz merged commit 0e3d9cd into nrwl:master Feb 10, 2023
@philipjfulcher philipjfulcher deleted the task-graph-thrown-error branch February 13, 2023 21:25
@github-actions
Copy link

github-actions bot commented Mar 3, 2023

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants